FS#54675 - [seahorse] No entries for "GnuPG keys" and "OpenSSH keys" shown

Attached to Project: Arch Linux
Opened by Stefan (steinwanderer) - Monday, 03 July 2017, 16:35 GMT
Last edited by Jan de Groot (JGC) - Thursday, 05 October 2017, 21:09 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 10
Private No

Details

Description:

No entries for "GnuPG keys" and "OpenSSH keys" are shown in the UI. Please refer to the attached screenshot.
Downgrading seahorse 3.20.0+94+g4c671a78-1 to 3.20.0-1 fixed this for me.

Additional info:

* package version(s)

seahorse 3.20.0+94+g4c671a78-1

Steps to reproduce:

$LANG=C seahorse

(seahorse:4357): GLib-GObject-CRITICAL **: g_object_class_install_property: assertion 'class->set_property != NULL' failed
(seahorse:4357): GLib-GObject-CRITICAL **: Object class SeahorseGpgmeKeyring doesn't implement property 'label' from interface 'SeahorsePlace'
(seahorse:4357): GLib-GObject-CRITICAL **: g_object_class_install_property: assertion 'class->set_property != NULL' failed
(seahorse:4357): GLib-GObject-CRITICAL **: Object class SeahorseUnknownSource doesn't implement property 'label' from interface 'SeahorsePlace'
(seahorse:4357): GLib-GObject-CRITICAL **: Flags for property 'label' on class 'SeahorseServerSource' remove functionality compared with the property on interface 'SeahorsePlace'
(seahorse:4357): GLib-GObject-CRITICAL **: g_object_class_install_property: assertion 'class->set_property != NULL' failed
(seahorse:4357): GLib-GObject-CRITICAL **: Object class SeahorseSSHSource doesn't implement property 'label' from interface 'SeahorsePlace'
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseSSHSource' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseGpgmeKeyring' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
(seahorse:4357): Gtk-WARNING **: (gtkicontheme.c:5493):gtk_icon_theme_lookup_by_gicon_for_scale: runtime check failed: ((flags & GTK_ICON_LOOKUP_GENERIC_FALLBACK) == 0)
(seahorse:4357): Gtk-WARNING **: (gtkicontheme.c:2226):gtk_icon_theme_choose_icon_for_scale: runtime check failed: ((flags & GTK_ICON_LOOKUP_GENERIC_FALLBACK) == 0)
(seahorse:4357): Gtk-WARNING **: (gtkicontheme.c:5493):gtk_icon_theme_lookup_by_gicon_for_scale: runtime check failed: ((flags & GTK_ICON_LOOKUP_GENERIC_FALLBACK) == 0)
(seahorse:4357): Gtk-WARNING **: (gtkicontheme.c:2226):gtk_icon_theme_choose_icon_for_scale: runtime check failed: ((flags & GTK_ICON_LOOKUP_GENERIC_FALLBACK) == 0)
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseSSHSource' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseGpgmeKeyring' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseSSHSource' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
(seahorse:4357): GLib-GObject-WARNING **: g_object_get_valist: object class 'SeahorseGpgmeKeyring' has no property named 'label'
(seahorse:4357): seahorse-CRITICAL **: update_backend: assertion 'spec != NULL' failed
   Bildschirmfoto von »2017-07-0... (20.9 KiB)
This task depends upon

Closed by  Jan de Groot (JGC)
Thursday, 05 October 2017, 21:09 GMT
Reason for closing:  Fixed
Comment by Yannick WEBER (yweb) - Saturday, 08 July 2017, 00:46 GMT
Problem, I changed my computer and have had to reinstall arch, gnome, etc... given that seahorse-3.20-1 or 3.20-2 are not in repos anymore I can't do the downgrade !
Comment by Jonathon (jonathon) - Sunday, 20 August 2017, 21:27 GMT
I've tried building from master back to the first commit that builds (https://git.gnome.org/browse/seahorse/commit/?id=7f64db1151ef95cdf2316c5ed34459d3076685d3) and the issue persists.

There's only one remaining (post-3.20) non-translation commit from before the working commit above: https://git.gnome.org/browse/seahorse/commit/?id=82daa60c6c67c1a054850e486b0303b82af3c84e

diff --git a/gkr/gkr-item-properties.vala b/gkr/gkr-item-properties.vala
index df3dabd..9e6e89d 100644
--- a/gkr/gkr-item-properties.vala
+++ b/gkr/gkr-item-properties.vala
@@ -260,6 +260,8 @@ public class ItemProperties : Gtk.Dialog {
{
if (this._updating_description)
return;
+ if (this.item.label == description.text)
+ return;

this._updating_description = true;
description.sensitive = false;

This looks promising given the seahorse messages ("object class 'SeahorseSSHSource' has no property named 'label'"). I'll try to revert that onto HEAD.

Edit: Nope, no difference.
Comment by helle vaanzinn (glitsj16) - Saturday, 02 September 2017, 01:31 GMT
Upstream is aware of the issue, cfr. https://bugzilla.gnome.org/show_bug.cgi?id=785849. Contacted ricotz (who made several vala related commits to the seahorse repo) via IRC at #vala irc.gnome.org. He kindly pointed to the upstream bug report and could reproduce the issue. A proper upstream fix is in the works. Untill then Arch Linux users can use the attached PKGBUILD to get GnuPG/OpenSSH keys showing up in seahorse. It falls back to sourcing the 3.20.0 release tarball, cherry-picks 2 additional commits from upstream repo and disables valac. Obviously not elegant, dropping all upstream translation commits post 3.20.0 in the process...
   PKGBUILD (1.4 KiB)
   fix.key.considered.patch (2 KiB)
   fix.key.description.patch (1.3 KiB)
Comment by helle vaanzinn (glitsj16) - Monday, 04 September 2017, 16:26 GMT
Follow-up. Ricotz has added a patch to the upstream bug report https://bugzilla.gnome.org/show_bug.cgi?id=785849. I've tested it (the patch mentioned in comment 2) and for me it only partly solves the issue. Building with the patch resolves showing OpenSSH keys in seahorse, but GnuPG keys still don't show. No critical errors in terminal. I've contacted ricotz about this but it would be nice if more testers could confirm/deny the status of the aforementioned patch (from comment 2)...
Comment by Jonathon (jonathon) - Monday, 04 September 2017, 17:58 GMT
Can confirm the patch applies against HEAD and shows OpenSSH keys again, but no GnuPG keys (attached PKGBUILD builds against HEAD). I've added a comment to the upstream report.
   PKGBUILD (1.3 KiB)
   Add-dummy-label-property-sett... (8.4 KiB)
   seahorse-yes-ssh-no-gpg.png (8.3 KiB)
Comment by helle vaanzinn (glitsj16) - Monday, 04 September 2017, 22:10 GMT
After another extended conversation with ricotz on IRC I found the culprit. The upstream patch by ricotz (https://bugzilla.gnome.org/attachment.cgi?id=358993) turns out to be just fine. Current gnupg version on Arch Linux (2.2.0) isn't getting recognized during ./configure (which I can't really explain). This results in LDAP and HKP being disabled as well. After changing GNUPG_ACCEPTED="2.0.12 2.1.4" to GNUPG_ACCEPTED="2.2.0" in ./configure.ac things start falling into place and result in a succesful build. Now, both OpenSSH/GnuPG keys properly show up in the sidebar again.

@jonathon: could you do another test?
   PKGBUILD (1.5 KiB)
   Add-dummy-label-property-sett... (8.4 KiB)
Comment by helle vaanzinn (glitsj16) - Tuesday, 05 September 2017, 05:14 GMT
Upstream master now has both patches to fix this issue. Regular PKGBUILD using commit b31e32fe145a6599096cebf9fba93d86090c6d90 works as expected again.
Comment by Jonathon (jonathon) - Tuesday, 05 September 2017, 18:19 GMT
Yay! Confirming fixed. :)

Loading...