FS#79614 - [fwupd] make libpassim.so optional
Attached to Project:
Arch Linux
Opened by CS (JMP64i) - Thursday, 07 September 2023, 22:42 GMT
Last edited by freswa (frederik) - Tuesday, 19 September 2023, 21:32 GMT
Opened by CS (JMP64i) - Thursday, 07 September 2023, 22:42 GMT
Last edited by freswa (frederik) - Tuesday, 19 September 2023, 21:32 GMT
|
Details
Description:
libpassim.so is an optional dependency: https://github.com/fwupd/fwupd/blob/9f085f137c4f8d5b209eaad7e5d83311f58c6b48/docs/fwupd.conf.md?plain=1#L192 As I have not installed avahi, passim service fails to start. I don't need passim or avahi. |
This task depends upon
Closed by freswa (frederik)
Tuesday, 19 September 2023, 21:32 GMT
Reason for closing: Won't fix
Additional comments about closing: We don't do split packages for libs.
Tuesday, 19 September 2023, 21:32 GMT
Reason for closing: Won't fix
Additional comments about closing: We don't do split packages for libs.
$ readelf -d /usr/lib/fwupd-1.9.5/libfwupdengine.so | grep passim
0x0000000000000001 (NEEDED) Shared library: [libpassim.so.1]
$ fwupdtool -h
fwupdtool: error while loading shared libraries: libpassim.so.1: cannot open shared object file: No such file or directory
Dunno. Maybe if passim libs were split out? Someone would need to test it. But is it worth it? Maybe there's another way to prevent the service fail?
Up to the package owners if they want to build without it (IMHO preferable, passim depending on avahi isn't great as evidenced by this request).
FWIW the required changes are:
--- PKGBUILD
+++ PKGBUILD
@@ -26,7 +26,6 @@
libjcat
libjson-glib-1.0.so
libmm-glib.so
- libpassim.so
libprotobuf-c.so
libqmi-glib.so
libsmbios
@@ -78,7 +77,8 @@
-D docs=enabled \
-D plugin_intel_spi=true \
-D supported_build=enabled \
- -D efi_binary=false
+ -D efi_binary=false \
+ -D passim=disabled
meson compile -C build
}
You as the packager need to decide if you want to build without it or not. With will force Arch users to have passim and its dependencies (the current way), without will prevent Arch users from using the new passim cache (unless they build it themselves or make an aur version with passim enabled).
Please note that tons of packages and projects have build-time-only decisions about what is and isn't optional, fwupd isn't being weird here.
https://github.com/fwupd/fwupd/issues/6179#issuecomment-1717299772