FS#66536 - [kodi] Missing dependency on which

Attached to Project: Community Packages
Opened by Daan De Meyer (DaanDeMeyer) - Monday, 04 May 2020, 18:16 GMT
Last edited by Ike Devolder (BlackEagle) - Monday, 08 June 2020, 11:02 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ike Devolder (BlackEagle)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

which is required but not a dependency:

Steps to reproduce:

cat /usr/bin/kodi-standalone | grep which
This task depends upon

Closed by  Ike Devolder (BlackEagle)
Monday, 08 June 2020, 11:02 GMT
Reason for closing:  Fixed
Additional comments about closing:  thanks for the patch, fixed in kodi 18.7.1
Comment by Eli Schwartz (eschwartz) - Tuesday, 05 May 2020, 03:14 GMT
This comes from the following file: https://github.com/xbmc/xbmc/blob/master/tools/Linux/kodi-standalone.sh.pulse

Personally I recommend submitting a PR to switch this from 'which' to 'command -v' as there's no valid reason to use "which" in a shellscript.
Comment by nl6720 (nl6720) - Tuesday, 05 May 2020, 09:40 GMT
I submitted a PR: https://github.com/xbmc/xbmc/pull/17804 .
Comment by Ike Devolder (BlackEagle) - Monday, 01 June 2020, 13:14 GMT
@nl6720 thanks, this change is also part of kodi 18.7
Comment by nl6720 (nl6720) - Tuesday, 02 June 2020, 12:28 GMT
No, it's not in 18.7 ( https://github.com/xbmc/xbmc/blob/18.7-Leia/tools/Linux/kodi-standalone.sh.pulse , https://github.com/xbmc/xbmc/blob/18.7.1-Leia/tools/Linux/kodi-standalone.sh.pulse ).
It'll only be in kodi 19.
Comment by Ike Devolder (BlackEagle) - Wednesday, 03 June 2020, 06:17 GMT
Yeah you're right, the release tarball for 18.7 I got was fucked up and contained 19

Loading...