FS#6161 - /arch/setup (CVS) new umount code pollutes stdout

Attached to Project: Arch Linux
Opened by Dennis Herbrich (gyroplast) - Thursday, 04 January 2007, 14:44 GMT
Task Type Feature Request
Category Installation
Status Closed
Assigned To Tobias Powalowski (tpowa)
Architecture not specified
Severity Very Low
Priority Normal
Reported Version 0.7.2 Gimmick
Due in Version 0.8 Voodoo
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Regarding /arch/setup $Id: setup,v 1.131 2007/01/03 23:04:33 tpowa Exp $

The newly added code to automatically umount partitions spews usage info on stdout if nothing is mounted in $DESTDIR and below, as the grep command used as a parameter returns nothing in that case.
This doesn't break anything, it's just dead ugly, and considering that it's the norm during the installation that nothing is mounted in $DESTDIR when choosing one of the harddisk preparation tasks, it's probably a good idea to redirect stdout to stderr here. It's scary to see "errors" whiz by. ;)

The code in question appears in lines 446/447. 520/521, and 624/625.
This task depends upon

Closed by  Tobias Powalowski (tpowa)
Thursday, 04 January 2007, 18:25 GMT
Reason for closing:  Fixed
Comment by Tobias Powalowski (tpowa) - Thursday, 04 January 2007, 18:18 GMT
ah yes thanks for mentioning didn't looked at the output

Loading...