FS#6161 - /arch/setup (CVS) new umount code pollutes stdout
Attached to Project:
Arch Linux
Opened by Dennis Herbrich (gyroplast) - Thursday, 04 January 2007, 14:44 GMT
Opened by Dennis Herbrich (gyroplast) - Thursday, 04 January 2007, 14:44 GMT
|
Details
Regarding /arch/setup $Id: setup,v 1.131 2007/01/03 23:04:33
tpowa Exp $
The newly added code to automatically umount partitions spews usage info on stdout if nothing is mounted in $DESTDIR and below, as the grep command used as a parameter returns nothing in that case. This doesn't break anything, it's just dead ugly, and considering that it's the norm during the installation that nothing is mounted in $DESTDIR when choosing one of the harddisk preparation tasks, it's probably a good idea to redirect stdout to stderr here. It's scary to see "errors" whiz by. ;) The code in question appears in lines 446/447. 520/521, and 624/625. |
This task depends upon
Comment by
Tobias Powalowski (tpowa) - Thursday,
04 January 2007, 18:18 GMT
ah yes thanks for mentioning didn't looked at the output