FS#58662 : [xorg-server] xfwm crashes with compositing

FS#58662 - [xorg-server] xfwm crashes with compositing

Attached to Project: Arch Linux
Opened by Ilya Gorbunov (BuggerZ) - Saturday, 19 May 2018, 11:27 GMT
Last edited by Andreas Radke (AndyRTR) - Sunday, 10 June 2018, 18:26 GMT

Task Type	Bug Report
Category	Upstream Bugs
Status	Closed
Assigned To	Jan de Groot (JGC) Andreas Radke (AndyRTR) Laurent Carlier (lordheavy)
Architecture	All
Severity	High
Priority	Normal
Reported Version
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	4 Sergey Vlasov (sigprof) (2018-06-09) sergi (sergi34) (2018-05-26) Daniel Willard (dwillar) (2018-05-25) Ilya Gorbunov (BuggerZ) (2018-05-19)
Private	No

Details

Description:
XFWM compiled with the {enable-compositor} option does not allow running the environment with xorg-server 1.20.
The environment does not start.

Additional info:
xfwm4 - version 4.12.4-1

Steps to reproduce:
1) Install xorg-server 1.20
2) run the xfce environment

Steps to fix:
Assemble the xfwm4 package with the disable-compositor option

fix_PKGBUILD (0.8 KiB)

This task depends upon

Closed by Andreas Radke (AndyRTR)
Sunday, 10 June 2018, 18:26 GMT
Reason for closing: Fixed

Comment by Doug Newgard (Scimmia) - Saturday, 19 May 2018, 13:50 GMT

Log? Backtraces? Anything useful at all?

This is more likely a driver issue.

Comment by loqs (loqs) - Saturday, 19 May 2018, 14:02 GMT

@Scimmia https://bbs.archlinux.org/viewtopic.php?pid=1786010#p1786010

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 19 May 2018, 14:03 GMT

Alas. 3 days tried to correct this mistake - on the fourth day decided. But there are no more messages left in the log.

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 19 May 2018, 14:12 GMT

@Scimmia This happens both on open drivers and on proprietary drivers.

Comment by Jan de Groot (JGC) - Saturday, 19 May 2018, 20:15 GMT

This is not a bug in xfwm4, but Xorg or drivers. X should not segfault.

Comment by Leonid Isaev (lisaev) - Sunday, 20 May 2018, 03:38 GMT

Would it help if xfwm4 is run with --compositor=off option?

Comment by Ilya Gorbunov (BuggerZ) - Sunday, 20 May 2018, 05:30 GMT

@lisaev Yes.

Comment by MrM (Mascarpone) - Friday, 25 May 2018, 08:45 GMT

Disabling the compositor works, now we have to wait for a fix for xorg?

Comment by Ilya Gorbunov (BuggerZ) - Friday, 25 May 2018, 09:28 GMT

@Mascarpone Yes. There was an error in it.

Comment by loqs (loqs) - Friday, 25 May 2018, 13:34 GMT

https://www.linuxquestions.org/questions/slackware-14/slackware-current-xorg-server-1-20-0-with-xf86-video-nouveau-segfaults-4175629581/page2.html#post5858058
Is upstream xorg aware of the issue?
Edit:
Can someone affected try reverting https://cgit.freedesktop.org/xorg/xserver/commit/?id=8171d4c2d67b2990a278dc018ac32534c3afe606
or fix miRenderColorToPixel to assume a default format if unset
possibly something like

struct _PictFormat tempPF;

if(!format)
{
tempPF.depth = 32;
tempPF.type = PictTypeDirect;
tempPF.direct.alpha = 24;
tempPF.direct.red = 16;
tempPF.direct.green = 8;
tempPF.direct.blue = 0;
tempPF.direct.redMask = 0xff;
tempPF.direct.greenMask = 0xff;
tempPF.direct.blueMask = 0xff;
tempPF.direct.alphaMask = 0xff;
format = &tempPF;
}

Comment by sergi (sergi34) - Friday, 25 May 2018, 19:51 GMT

same problem here. I'll wait for the fix. In the meanwhile downgrading to 1.19 just works. Compositor is one of the great things in xfce4

Comment by Darek (blablo) - Friday, 25 May 2018, 20:53 GMT

>Steps to reproduce:
>1) Install xorg-server 1.20
>2) run the xfce environment

It happens with 'xorg-server 1.20.0-2' or 'xorg-server 1.20.0-4'?
Edit
If 2 then please check 4

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 26 May 2018, 11:37 GMT

@blablo OK. I'll check it out soon. At the time of decision, the bug went to the openbox.
Update > checked - on version xorg 1.20.0-5 - still does not work.

Comment by Darek (blablo) - Saturday, 26 May 2018, 12:21 GMT

https://bugzilla.xfce.org/show_bug.cgi?id=14366
edit
please see https://wiki.archlinux.org/index.php/Reporting_bug_guidelines#Gather_useful_information

Comment by loqs (loqs) - Saturday, 26 May 2018, 15:41 GMT

Please try this PKGBUILD to use:
# pacman -S base-devel devtools
git clone git://git.archlinux.org/svntogit/packages.git --single-branch --branch "packages/xorg-server"
cd packages/trunk/ #replace existing PKGBUILD with the one attached to this comment
gpg --add-keys 4C09DD83CAAA50B2
testing-x86_64-build
pacman -U xorg-server-1.20.0-5-x86_64.pkg.tar.xz xorg-server-common-1.20.0-5-x86_64.pkg.tar.xz

PKGBUILD (9.2 KiB)

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 26 May 2018, 15:54 GMT

@blablo You are welcome.

journalctl (1.2 KiB)

Xorg.0.log (26.2 KiB)

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 26 May 2018, 16:13 GMT

@loqs It worked! The environment was successfully launched.

Comment by Darek (blablo) - Saturday, 26 May 2018, 16:56 GMT

> @loqs It worked! The environment was successfully launched.
Please, open an bug report on https://bugs.freedesktop.org/describecomponents.cgi?product=xorg Thanks

Comment by Ilya Gorbunov (BuggerZ) - Saturday, 26 May 2018, 17:36 GMT

@blablo I'd love to, but do not know what component xorg error is.

Comment by loqs (loqs) - Saturday, 26 May 2018, 18:13 GMT

Server/Acceleration/EXA is where the bug is occurring although it could also be Server/General as the commit that introduced it touched glamor and fb as well.
Attempted patch based on suggestion from seth. Only difference from previous build instructions is place the xorg-server.patch in the same directory as well.

PKGBUILD (9.1 KiB)