FS#13263 - [initscripts] Fix array count/walk in rc.shutdown and rc.single
Attached to Project:
Arch Linux
Opened by Gerardo Exequiel Pozzi (djgera) - Friday, 13 February 2009, 21:02 GMT
Last edited by Thomas Bächler (brain0) - Sunday, 07 June 2009, 19:35 GMT
Opened by Gerardo Exequiel Pozzi (djgera) - Friday, 13 February 2009, 21:02 GMT
Last edited by Thomas Bächler (brain0) - Sunday, 07 June 2009, 19:35 GMT
|
Details
Hi,
When counting elements of DAEMONS array these are counted OK, but when this is walked it start from this count, then visit an inexistent element. Then should be count minus one, (zero based arrays). Trivial fix is attached for rc.single and rc.shutdown There are three attachd files: initscripts-2009.01-1.rcshutdown.arraycount.fix.patch This is for initscripts-2009.01-1 (applied ok with latest commit of initscripts-2009.01-1.rcsingle.arraycount.fix.patch (same here) initscripts-2009.01-1-plus-FS12978.rcsingle.arraycount.fix.patch and this is in the case if this Thanks. |
This task depends upon
Closed by Thomas Bächler (brain0)
Sunday, 07 June 2009, 19:35 GMT
Reason for closing: Fixed
Additional comments about closing: fixed in git
Sunday, 07 June 2009, 19:35 GMT
Reason for closing: Fixed
Additional comments about closing: fixed in git
Comment by
Gerardo Exequiel Pozzi (djgera) -
Friday, 13 February 2009, 21:05 GMT
Comment by
Aaron Griffin (phrakture) - Friday,
13 February 2009, 21:25 GMT
Comment by Thomas Bächler (brain0) -
Sunday, 07 June 2009, 14:35 GMT
Comment by
Gerardo Exequiel Pozzi (djgera) -
Sunday, 07 June 2009, 18:45 GMT
Oooh writing FS#nnnnn is automagically converted to link, cool :P
- Field changed: Status (Unconfirmed → Assigned)
- Task assigned to Aaron Griffin (phrakture), Thomas Bächler (brain0)
Patch looks ok - need to confirm the logic here, though
Just checked it, it is correct, commiting to git.
Thanks Thomas, requesting closure...