FS#13205 - [PATCH] initscripts: better random-seed entropy and other things
Attached to Project:
Arch Linux
Opened by Gerardo Exequiel Pozzi (djgera) - Wednesday, 11 February 2009, 15:31 GMT
Last edited by Thomas Bächler (brain0) - Wednesday, 11 February 2009, 21:10 GMT
Opened by Gerardo Exequiel Pozzi (djgera) - Wednesday, 11 February 2009, 15:31 GMT
Last edited by Thomas Bächler (brain0) - Wednesday, 11 February 2009, 21:10 GMT
|
Details
Hi,
Some points: *** The random-seed file location to be more "FHS compliant" is better to put in /var/lib/misc/random-seed (Variable state information, that persist after reboot) than the /var/run/random-seed (Run-time variable data, that not necessary persists after reboot) for example with /var/run mounted as TMPFS. (this is the _principal_ reason of why created this patch) ** The random-seed file permision should be "0600" not "0644" (OK, actually this file is removed in rc.sysinit at "the clean" step. * The size of random-seed acording to random(4) manpage should be the size specified in "/proc/sys/kernel/random/poolsize" in other case 512 bytes. The patch is attached ;) 
random-seed.patch
(1 KiB)
|
This task depends upon
Closed by Thomas Bächler (brain0)
Wednesday, 11 February 2009, 21:10 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in git.
Wednesday, 11 February 2009, 21:10 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in git.
Thomas, opinions? I haven't looked at the patch yet, but the explanation seems solid.
+[ -r $POOL_FILE ] && POOL_SIZE=$(/bin/cat $POOL_FILE) || POOL_SIZE=512
Sometimes constructs containing both && and || behaved weird to me (now that I think about it, it should be okay the way you wrote it). For more readability, please use if/then/else at this point.
Furthermore, if you want credit for your patch in the logs, please resend it as a git-formatted patch against http://projects.archlinux.org/?p=initscripts.git;a=summary
No problem for credits, commit without it, thanks ;)
Thanks for applying it. :D