FS#9295 - pacman 3.1.0 is not clear about updating itself

Attached to Project: Pacman
Opened by Stefan O. (hybrid) - Tuesday, 22 January 2008, 05:54 GMT
Last edited by Xavier (shining) - Sunday, 27 January 2008, 20:32 GMT
Task Type Bug Report
Category General
Status Closed
Assigned To Xavier (shining)
Architecture All
Severity Low
Priority Normal
Reported Version 3.1.0
Due in Version 3.1.2
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When I upgraded pacman from 3.1.0-1 to 3.1.1-1 through pacman -Syu I got the "pacman has detected a newer version of itself" message but then was asked whether I want to cancel the current operation.
But that is in contradiction to the "pacman has detected a new version" message and yes and now still cause the old behaviour: yes upgrades and no aborts.
I feel kinda reatardid opening a bugreport for something as little as this, but it's inconsistent and not clear what's meant, especially newbs might(should) get confused. I dunno if this "bug" (think it's just calling the wrong message) got fixed in 3.1.1 already since the version that produced it was 3.1.0.

In case you don't get what I mean, I attached the pacman output.
   pacman-inconsistent.txt (1.2 KiB)
This task depends upon

Closed by  Xavier (shining)
Sunday, 27 January 2008, 20:32 GMT
Reason for closing:  Fixed
Additional comments about closing:  fixed by commit 0775c38e72c0
Comment by Xavier (shining) - Tuesday, 22 January 2008, 10:15 GMT
If you had a better suggestion for the message, it would be much appreciated :)
Comment by Nagy Gabor (combo) - Tuesday, 22 January 2008, 12:12 GMT
"I feel kinda reatardid opening a bugreport for something as little as this,"

No problem. Cleanly that message is odd, and we will change it.
Comment by Stefan O. (hybrid) - Tuesday, 22 January 2008, 15:56 GMT
Well I guess the messages "pacman has found a new version..." and "Cancel current operation? [Y/n]" do line up, but the handling of the user input (yes and no) doesn't and should be switched. So that "yes" will cancel and "no" will continue as the messages say, right now it's being the opposite.
Comment by Xavier (shining) - Tuesday, 22 January 2008, 17:01 GMT
The current operation is the upgrade of the system (-Su).
The recommended operation is the upgrade of pacman (-S pacman).

So if you choose to cancel the current operation, it cancels the system upgrade and does the recommended one : upgrading pacman.
If you don't want to cancel the current operation, it will go on with the system upgrade.
Comment by Aaron Griffin (phrakture) - Thursday, 24 January 2008, 00:31 GMT
How about we just switch the last part to "Do you want to cancel the current operation and install the new pacman now? [Y/n]"
Comment by Xavier (shining) - Thursday, 24 January 2008, 10:25 GMT
That last sentence sounds good to me, but I am not sure if the previous ones are necessary.
There is no need to manually 'pacman -S pacman', since pacman already handles that automatically when you answer yes.
So if we keep this behavior in pacman, I would change the whole message to just this:

:: pacman has detected a newer version of itself.
:: Do you want to cancel the current operation and
:: install the new pacman now? [Y/n]
Comment by Nagy Gabor (combo) - Thursday, 24 January 2008, 19:46 GMT
I like the last version.
Comment by Xavier (shining) - Sunday, 27 January 2008, 20:31 GMT
Ok, that last version is now in pacman, see commit 0775c38e72c0.

Loading...