FS#9184 - Some bugs in mkarchroot/makechrootpkg

Attached to Project: Pacman
Opened by Jaroslaw Swierczynski (swiergot) - Sunday, 13 January 2008, 09:03 GMT
Last edited by Dan McGee (toofishes) - Thursday, 07 February 2008, 04:41 GMT
Task Type Bug Report
Category Scripts & Tools
Status Closed
Assigned To Simo Leone (neotuli)
Aaron Griffin (phrakture)
Dan McGee (toofishes)
Architecture All
Severity Low
Priority Normal
Reported Version git
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I've found two bugs. Attached is a patch that fixes them.
   devtools.patch (0.9 KiB)
This task depends upon

Closed by  Dan McGee (toofishes)
Thursday, 07 February 2008, 04:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  Aaron's working branch merged to master and tagged/released as devtools-0.5
Comment by Xavier (shining) - Sunday, 13 January 2008, 09:46 GMT
Just for your information, I believe you can simply remove the --dbpath line, since the path you specified is the default one pacman will use.
Same for cachedir.

But it might be better to specify them explicitly, I don't know.
Comment by Jaroslaw Swierczynski (swiergot) - Sunday, 13 January 2008, 10:08 GMT
If dbpath is under chroot by default then ok. But cachedir better not be inside chroot so that we have one package cache and we don't need to download some packages twice.
Comment by Xavier (shining) - Sunday, 13 January 2008, 10:15 GMT
Yes, that's also the default in 3.1 for the package cache.
Try : pacman -v -r foo/
Comment by Dan McGee (toofishes) - Sunday, 13 January 2008, 18:42 GMT
Looks good to me if you take Xavier's comments into account (no need to specify dbpath anymore, so I would drop that).

If anyone else wants to take charge on this and get a new set of devtools released with this and  bug 9196 , that would be good.
Comment by Dan McGee (toofishes) - Sunday, 13 January 2008, 18:43 GMT
 bug 9177  too.
Comment by Aaron Griffin (phrakture) - Monday, 14 January 2008, 17:12 GMT
Dan: We have _many_ devtools changes incoming, so please don't jump the gun and release a new one. I will take these into account. I also have 4 patches coming from Travis as well.
Comment by Dan McGee (toofishes) - Monday, 14 January 2008, 17:35 GMT
I wasn't planning on it, but you should get to it ASAP- someone is going to break their local DB with the current condition of devtools as the meaning of --dbpath has changed.

It would be better to release a bugfix version first than wait out for every single devtools patch to come rolling in.
Comment by Aaron Griffin (phrakture) - Wednesday, 16 January 2008, 18:56 GMT
re: Xavier
http://code.phraktured.net/?p=devtools.git;a=commitdiff;h=a60753adcd05963b538bf0035fbb55ca67545bd3

re: other bug in this report (one bug report, two bugs....)
http://code.phraktured.net/?p=devtools.git;a=commitdiff;h=20c3fb2177d862d13486816f80dfafdba790af5c

Loading...