FS#8579 - initscripts: unable to load multiple keymaps

Attached to Project: Arch Linux
Opened by nackd (Prieto) - Thursday, 08 November 2007, 19:43 GMT
Last edited by Roman Kyrylych (Romashka) - Thursday, 28 February 2008, 10:29 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Tobias Powalowski (tpowa)
Thomas Bächler (brain0)
Roman Kyrylych (Romashka)
Architecture All
Severity Low
Priority Normal
Reported Version 2007.08-2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

My KEYMAP config in rc.conf reads:

--
KEYMAP="es euro2"
--

(For some reason the setup for the euro sign is split in its own file, so I need to load both maps). This had always worked fine until recently. From this [1] change onwards, loadkeys is invoked with KEYMAP quoted, so variable content is interpreted as a single word and, thus, fails.

I think it is safe to remove the quotes.

[1] http://projects.archlinux.org/git/?p=initscripts.git;a=commitdiff;h=fa4866f0adce9c3e0bfc09fb878eebb99797c338
This task depends upon

Closed by  Roman Kyrylych (Romashka)
Thursday, 28 February 2008, 10:29 GMT
Reason for closing:  Fixed
Comment by Roman Kyrylych (Romashka) - Friday, 09 November 2007, 09:51 GMT
Hm, I see there's a lot of such keymaps that add some functionality to base keymap: find /usr/share/kbd/keymaps | grep include
Here's a patch that fixes this, as well as improves error handling for keymap and fonts loading (they can be easily mistyped but rc.sysinit didn't produce errors).
Please test.

   0001-Improve-error-handling-a... (1.4 KiB)
Comment by Roman Kyrylych (Romashka) - Friday, 09 November 2007, 10:29 GMT
Ignore my previous patch.

This one is tested and good:
   0001-Improve-error-handling-a... (1.7 KiB)
Comment by nackd (Prieto) - Friday, 09 November 2007, 14:22 GMT
It works, but if I try to setup a non-existent CONSOLEFONT, the status line shows both FAIL and DONE:

---
:: Loading Keyboard Map: es euro2 in utf-8 mode [DONE]
:: Loading Console Font: lat9w-16aa [FAIL]
[DONE]
---
Comment by Roman Kyrylych (Romashka) - Friday, 09 November 2007, 14:43 GMT
Thanks, fixed now.
EDIT: fixed typo, I hope this is the last.
   0001-Improve-error-handling-a... (2.2 KiB)
Comment by Thomas Bächler (brain0) - Friday, 09 November 2007, 15:07 GMT
Roman, I trust you tested this well, so I'll apply it to initscripts git.
Comment by nackd (Prieto) - Friday, 09 November 2007, 17:06 GMT
It is perfect now. Thanks Roman.
Comment by Aaron Griffin (phrakture) - Friday, 11 January 2008, 20:47 GMT
Crap, ignore me. Already applied

Loading...