FS#78982 - [abseil-cpp] CMAKE_POSITION_INDEPENDENT_CODE ?

Attached to Project: Arch Linux
Opened by Michel (xantares) - Tuesday, 04 July 2023, 16:19 GMT
Last edited by Massimiliano Torromeo (mtorromeo) - Saturday, 29 July 2023, 09:15 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Massimiliano Torromeo (mtorromeo)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

why do you set CMAKE_POSITION_INDEPENDENT_CODE ?

it seems the package provides shared libs anyways
This task depends upon

Closed by  Massimiliano Torromeo (mtorromeo)
Saturday, 29 July 2023, 09:15 GMT
Reason for closing:  Fixed
Additional comments about closing:  abseil-cpp-20230125.3-2
Comment by Michel (xantares) - Wednesday, 05 July 2023, 16:47 GMT
also it should be built in Release mode, not RelWithDebInfo (so DNDEBUG flag will not be needed)
Comment by Antonio Rojas (arojas) - Wednesday, 05 July 2023, 17:11 GMT
CMAKE_BUILD_TYPE=RelWithDebInfo (or None) is correct as per the Arch packaging guidelines to get useful debug traces. But the line "-DCMAKE_CXX_FLAGS="-DNDEBUG"" is wrong as it is overwriting the system flags instead of appending. This was changed in https://gitlab.archlinux.org/archlinux/packaging/packages/abseil-cpp/-/commit/3fc970a19e2f3393696dc9363b7aee91bc36e333

Loading...