FS#78767 - [neovide] Current build flags will likely cause a memory leak in next release

Attached to Project: Arch Linux
Opened by AThePeanut4 (AThePeanut4) - Monday, 12 June 2023, 15:47 GMT
Last edited by Caleb Maclennan (alerque) - Friday, 16 June 2023, 14:13 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Caleb Maclennan (alerque)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

In the next release version of neovide, the current build flags (`--all-features`) will likely cause a memory leak.

Recently profiling support was introduced, which is enabled using the `profiling` and `gpu_profiling` features. When these features are enabled, the application will buffer all profiling data in memory until the profiling client connects. If the client does not connect, it effectively causes a memory leak.

This behaviour is expected, see upstream issue https://github.com/neovide/neovide/issues/1892 , so to prevent this happening the program should not be compiled with profiling support (no `--all-features`).

For now this is not an issue, but as the next release version will probably include the new profiling support, I thought I'd make this report now so the issue is known.
This task depends upon

Closed by  Caleb Maclennan (alerque)
Friday, 16 June 2023, 14:13 GMT
Reason for closing:  Fixed
Comment by Caleb Maclennan (alerque) - Friday, 16 June 2023, 14:13 GMT
Pre-empted, but this should *also* be corrected upstream, profiling stuff should be part of the profiling profile not the release profile.

Loading...