FS#78667 - [electron24] PKGBUILD suggestions
Attached to Project:
Community Packages
Opened by loqs (loqs) - Thursday, 01 June 2023, 00:52 GMT
Last edited by Caleb Maclennan (alerque) - Monday, 12 June 2023, 21:12 GMT
Opened by loqs (loqs) - Thursday, 01 June 2023, 00:52 GMT
Last edited by Caleb Maclennan (alerque) - Monday, 12 June 2023, 21:12 GMT
|
Details
Description:
In electron 23 plus use_system_libwayland = true Is no longer a used option producing: WARNING at the command-line "--args":18:29: Build argument has no effect. use_system_libwayland = true ^--- The variable "use_system_libwayland" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <out_dir>" The build continued as if that argument was unspecified. Similarly use_system_wayland_scanner = true produces WARNING at the command-line "--args":18:34: Build argument has no effect. use_system_wayland_scanner = true ^--- The variable "use_system_wayland_scanner" was set as a build argument but never appeared in a declare_args() block in any buildfile. To view all possible args, run "gn args --list <out_dir>" The build continued as if that argument was unspecified. Upstream bug report documenting removal [1]. They were dropped from the chromium package in [2] along with the dependency on wayland. Electron 22 moved to webpack version 5.73 in [3] which includes its own md4 implementation [4] so no longer needs export NODE_OPTIONS=--openssl-legacy-provider Additional info: * electron24 24.4.0-1 [1] https://crbug.com/1385736 [2] https://gitlab.archlinux.org/archlinux/packaging/packages/chromium/-/commit/e9b3a25112a2e1b7d4ba61e8f0a9569fbb8d2544 [3] https://github.com/electron/electron/commit/3baf7136481b57d2f11f0276c8b31f1b0ac6d23a [4] https://github.com/webpack/webpack/commit/0f6c78cca174a73184fdc0d9c9c2bd376b48557c Steps to reproduce: $ pkgctl repo clone --protocol=https electron24 $ cd electron24 $ extra-x86_64-build |
This task depends upon
electron20 can be dropped
FS#77673.electron21 is only used by bitwarden which supports electron24.
electron19 is used by cozy-desktop which if updated to 3.38.0 supports electron23 plus node and mattermost-desktop which if updated to 5.3.1 also supports supports electron23 plus node.
electron17 as discussed in
FS#77061is still needed.Do you have patch sets for all the electron builds you plan on doing?
At least the electron23 PKGBUILD [1] does not build. With the attached diff applied it built for me.
[1] https://gitlab.archlinux.org/archlinux/packaging/packages/electron23/-/commit/0dfcaedeee8a7c9058180b0ff5eff3e0e1c4ed4f
Edit:
Corrected diff to use https://chromium.googlesource.com/chromium/src.git rather than https://github.com/chromium/chromium.git#tag=$_chromiumver
PKGBUILD.diff (103.2 KiB)
23 is live, building 22 now. Have some other things to keep cleaning up and some unresolved discussions with other TUs about how to handle transitioning the base rolling version package, but thanks for moving the dial on this along significantly.
Thanks *so* much for the patches and tips and references.