FS#78667 - [electron24] PKGBUILD suggestions

Attached to Project: Community Packages
Opened by loqs (loqs) - Thursday, 01 June 2023, 00:52 GMT
Last edited by Caleb Maclennan (alerque) - Monday, 12 June 2023, 21:12 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Caleb Maclennan (alerque)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
In electron 23 plus
use_system_libwayland = true
Is no longer a used option producing:
WARNING at the command-line "--args":18:29: Build argument has no effect.
use_system_libwayland = true
^---
The variable "use_system_libwayland" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <out_dir>"

The build continued as if that argument was unspecified.

Similarly
use_system_wayland_scanner = true
produces
WARNING at the command-line "--args":18:34: Build argument has no effect.
use_system_wayland_scanner = true
^---
The variable "use_system_wayland_scanner" was set as a build argument
but never appeared in a declare_args() block in any buildfile.

To view all possible args, run "gn args --list <out_dir>"

The build continued as if that argument was unspecified.

Upstream bug report documenting removal [1]. They were dropped from the chromium package in [2] along with the dependency on wayland.

Electron 22 moved to webpack version 5.73 in [3] which includes its own md4 implementation [4] so no longer needs
export NODE_OPTIONS=--openssl-legacy-provider
Additional info:
* electron24 24.4.0-1
[1] https://crbug.com/1385736
[2] https://gitlab.archlinux.org/archlinux/packaging/packages/chromium/-/commit/e9b3a25112a2e1b7d4ba61e8f0a9569fbb8d2544
[3] https://github.com/electron/electron/commit/3baf7136481b57d2f11f0276c8b31f1b0ac6d23a
[4] https://github.com/webpack/webpack/commit/0f6c78cca174a73184fdc0d9c9c2bd376b48557c

Steps to reproduce:
$ pkgctl repo clone --protocol=https electron24
$ cd electron24
$ extra-x86_64-build
This task depends upon

Closed by  Caleb Maclennan (alerque)
Monday, 12 June 2023, 21:12 GMT
Reason for closing:  Fixed
Comment by Caleb Maclennan (alerque) - Thursday, 01 June 2023, 18:49 GMT
Roger that. I actually have a mental note to look into that dependency and which versions need it vs. which don't. This research is helpful. Builds will be trickling out with this fixed, but it will take a while. I have a least a dozen Electron builds (assuming nothing goes wrong with any of them which would take a miracle) before getting to this.
Comment by loqs (loqs) - Thursday, 01 June 2023, 19:18 GMT
> I have a least a dozen Electron builds
electron20 can be dropped  FS#77673 .
electron21 is only used by bitwarden which supports electron24.
electron19 is used by cozy-desktop which if updated to 3.38.0 supports electron23 plus node and mattermost-desktop which if updated to 5.3.1 also supports supports electron23 plus node.
electron17 as discussed in  FS#77061  is still needed.

Do you have patch sets for all the electron builds you plan on doing?
Comment by loqs (loqs) - Saturday, 03 June 2023, 00:15 GMT
> Do you have patch sets for all the electron builds you plan on doing?
At least the electron23 PKGBUILD [1] does not build. With the attached diff applied it built for me.

[1] https://gitlab.archlinux.org/archlinux/packaging/packages/electron23/-/commit/0dfcaedeee8a7c9058180b0ff5eff3e0e1c4ed4f
Comment by loqs (loqs) - Saturday, 03 June 2023, 20:21 GMT
The attached diff is for electron22.
Edit:
Corrected diff to use https://chromium.googlesource.com/chromium/src.git rather than https://github.com/chromium/chromium.git#tag=$_chromiumver
Comment by Caleb Maclennan (alerque) - Monday, 12 June 2023, 14:28 GMT
Wow thanks for these patches. Unfortunately I spent most of a week off and hacking on the same things getting *some* but not all of it duplicated before I saw that these patches were sitting here! My mistake for not catching the bug tracker notification. I'll be glad when we get MRs open on the GitLab packaging repos!

23 is live, building 22 now. Have some other things to keep cleaning up and some unresolved discussions with other TUs about how to handle transitioning the base rolling version package, but thanks for moving the dial on this along significantly.
Comment by Caleb Maclennan (alerque) - Monday, 12 June 2023, 21:12 GMT
24 and 25 are in testing with the improvements mentioned in this issue included. 22 is also rebuilt but I'm wrangling the pkgbase situation using new Git tooling and having some hook trouble. That should get resolved soon but is unrelated to this issue. Since the build patches here are applied to all 4 referenced versions I'm going to mark this as closed.

Thanks *so* much for the patches and tips and references.

Loading...