FS#76748 - [libbluray] Do not touch global git config
Attached to Project:
Arch Linux
Opened by Siegfried Metz (NiceGuy) - Monday, 05 December 2022, 17:06 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:17 GMT
Opened by Siegfried Metz (NiceGuy) - Monday, 05 December 2022, 17:06 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:17 GMT
|
Details
-1.3.4libbluray incorporated changes which should be
avoided. As can be seen with an example of
gnome-settings-daemon commit [1], global git config
modification should be avoided within a PKGBUILD.
"git -c protocol.file.allow=always submodule update" like documented in the official VSC guide [2] should be used, or something similar. This avoids touching users git config global settings. [1]: https://github.com/archlinux/svntogit-packages/commit/2d9d8a60bbea430a1c3cee8e9ef3609e67788fca [2]: https://wiki.archlinux.org/title/VCS_package_guidelines#Git_submodules Additional info: * libbluray-1.3.4 Steps to reproduce: Just a minor glitch in the matrix ;) git changed behavior for security, in order to use submodules, protocol.file.allow=always has to be used, but should be taken care of not to use --global scope. |
This task depends upon
Closed by Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:17 GMT
Reason for closing: Moved
Additional comments about closing: https://gitlab.archlinux.org/archlinux/p ackaging/packages/libbluray/issues/1
Saturday, 25 November 2023, 20:17 GMT
Reason for closing: Moved
Additional comments about closing: https://gitlab.archlinux.org/archlinux/p ackaging/packages/libbluray/issues/1
I see your point. Then again, maybe it was just overlooked. My intent was to point out how it's officially documented.
Somehow it is set for other PGKBUILDs this way. Either way, I'm ok with it. I really wish it is uniformly handled, that's all. :)