FS#76685 - [hplip] don't install ImageProcessor library

Attached to Project: Arch Linux
Opened by Letu Ren (FantasqueX) - Monday, 28 November 2022, 08:46 GMT
Last edited by Toolybird (Toolybird) - Thursday, 01 December 2022, 04:55 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Currently, ArchLinux uses `--disable-imageProcessor-build` to build hplip which disable to build ImageProcessor binding code. You can checkout configure.in and the only thing `--disable-imageProcessor-build` does is defining `DISABLE_IMAGEPROCESSOR` MACRO. If `DISABLE_IMAGEPROCESSOR` is defined, hplip won't build binding code using libImageProcessor.so and ImageProcessor.h. I think if it is appropriate not to build binding code, this library and header file shouldn't be installed.

There is a similar task I opened previously https://bugs.archlinux.org/task/76607. I have to apologize that I filed the issue before figuring out the problem.

Patches are attached.
   PKGBUILD.patch (2 KiB)
   Remove-ImageProcessor-binary-... (2.2 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Thursday, 01 December 2022, 04:55 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#76607 
Comment by Toolybird (Toolybird) - Monday, 28 November 2022, 21:26 GMT
Again, what problem are you trying to solve here? You've titled this ticket "don't install ImageProcessor library", but the ImageProcessor library is not actually installed with the current PKGBUILD recipe.

> I think if it is appropriate not to build binding code, this library and header file shouldn't be installed

But they're not (as already mentioned in  FS#76607 ). This seems like a pointless change. Please clarify your rationale.
Comment by Letu Ren (FantasqueX) - Tuesday, 29 November 2022, 07:58 GMT
My above comments are not accurate. .so and .h are not installed. There is only one caveat. `-lImageProcessor` is passed to linker through `hpcups_LDADD`. However, it isn't actually linked to hpcups because `sed -i -e 's/ -shared / -Wl,-O1,--as-needed\0/g' libtool` in PKGBUILD. Currently, there is no bug in PKGBUILD if `-Wl,--as-needed` works well.
Comment by Toolybird (Toolybird) - Thursday, 01 December 2022, 04:54 GMT
Ok, you're right in that `-lImageProcessor` is being unnecessarily passed on the link line. But luckily it makes no difference. I've just built the pkg twice, once as per normal and again with your patch then compared the resultant binaries and they are byte-for-byte identical.

Loading...