FS#76607 - [hplip] don't link unnecessary prebuilt ImageProcessor library

Attached to Project: Arch Linux
Opened by Letu Ren (FantasqueX) - Thursday, 17 November 2022, 05:56 GMT
Last edited by Toolybird (Toolybird) - Thursday, 17 November 2022, 21:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Currently hplip links an unnecessary prebuilt library. If we don't link this library, hplip can be built normally. So, I think it is possible to add a patch to prevent linking this library. Debian has already done that. Patch is attached.
Reference: https://salsa.debian.org/printing-team/hplip/-/blob/debian/main/debian/patches/0028-Remove-ImageProcessor-binary-installs.patch
   PKGBUILD.patch (2 KiB)
   0028-Remove-ImageProcessor-bi... (1.8 KiB)
This task depends upon

Closed by  Toolybird (Toolybird)
Thursday, 17 November 2022, 21:16 GMT
Reason for closing:  Not a bug
Additional comments about closing:  See comments
Comment by Toolybird (Toolybird) - Thursday, 17 November 2022, 06:53 GMT
Related  FS#59681 
Comment by Toolybird (Toolybird) - Thursday, 17 November 2022, 07:11 GMT
> Currently hplip links an unnecessary prebuilt library

Are you sure? AFAICT it doesn't. Sure, it's there in the src tarball but it doesn't get built, linked or installed in the Arch build. You can see for yourself if you study the logs. The Makefile does try to install it but fails due to lack of DESTDIR support.

cp: cannot create regular file '/usr/lib/libImageProcessor-x86_64.so': Permission denied
chmod: cannot access '/usr/lib/libImageProcessor-x86_64.so': No such file or directory
ln: failed to create symbolic link '/usr/lib/libImageProcessor.so': Permission denied

Edit: We used to have the patch but it was removed here [1]

[1] https://github.com/archlinux/svntogit-packages/commit/cb4d55e5
Comment by Letu Ren (FantasqueX) - Thursday, 17 November 2022, 08:40 GMT
Those install instructions are removed as well in my patch.

Why is it removed previously?
Comment by Andreas Radke (AndyRTR) - Thursday, 17 November 2022, 12:08 GMT
--disable-imageProcessor-build \ in that commit does the trick.

Loading...