FS#76361 - [mc] missing spell checking
Attached to Project:
Community Packages
Opened by Ralf Mardorf (Ralf) - Tuesday, 01 November 2022, 04:19 GMT
Last edited by George Rawlinson (rawlinsong) - Wednesday, 21 December 2022, 01:35 GMT
Opened by Ralf Mardorf (Ralf) - Tuesday, 01 November 2022, 04:19 GMT
Last edited by George Rawlinson (rawlinsong) - Wednesday, 21 December 2022, 01:35 GMT
|
Details
Hi, mcedit from the package community/mc 4.8.28-1 is missing
spell checking. Building in a clean chroot after adding
'aspell' to makedepends and adding --enable-aspell to
configure of the PKGBUILD solves the issue. Regards, Ralf
|
This task depends upon
Closed by George Rawlinson (rawlinsong)
Wednesday, 21 December 2022, 01:35 GMT
Reason for closing: Fixed
Additional comments about closing: 4.8.28-2
Wednesday, 21 December 2022, 01:35 GMT
Reason for closing: Fixed
Additional comments about closing: 4.8.28-2
[1] https://src.fedoraproject.org/rpms/mc/blob/rawhide/f/mc.spec#_163-166
If 1) mc is built with aspell 2) aspell libraries are installed, but 3) dictionaries are not found, the error message is shown:
https://github.com/MidnightCommander/mc/blob/7fe3f4c898d029e87faa439ebd7297214059f710/src/editor/spell.c#L318
If aspell libraries are not installed, or mc is built without aspell, then error message is not shown, even though the dictionaries are not present.
So just don't depend on aspell, and the message with not be shown. Otherwise we can change the logic (patches welcome), but so far, nobody complained in the last 10 years.
I can confirm that (for the details, check the source code I linked).
As I said, aspell libraries are loaded with `dlopen` at runtime. If they are not found, then no warning is shown. If they are found, but aspell is not functional, then a warning is shown. If they are found and aspell is functional, then spell check is enabled.
However, in order to have this functionality in the first place, aspell has to be present at the build time.
Yury.