FS#75150 - [grafana-zabbix] Redundant artifacts for other OS

Attached to Project: Community Packages
Opened by avimitin (avimitin) - Thursday, 23 June 2022, 07:12 GMT
Last edited by Robin Candau (Antiz) - Sunday, 19 November 2023, 16:44 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Florian Pritz (bluewind)
Robin Candau (Antiz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The `make dist` command will trigger build for Windows and MacOS Darwin. It is better to specify the GOOS variable. The attached patch split the `make dist` command into two different call: `make dist-frontend` and `make dist-backend-linux dist-arm-linux-arm-v6 dist-arm-linux-arm-v7 dist-arm-linux-arm64`.
   better-build.patch (0.4 KiB)
This task depends upon

Closed by  Robin Candau (Antiz)
Sunday, 19 November 2023, 16:44 GMT
Reason for closing:  Implemented
Additional comments about closing:  Implemented in v4.4.3-2
Comment by Robin Candau (Antiz) - Wednesday, 01 November 2023, 11:13 GMT
Hi,

Thanks for the suggestion and the patch!

Any reason why you included the backend build for `arm`?
Arch Linux only supports x86_64, can't the build be limited to `make dist-frontend` and `make dist-backend-linux`?
Comment by avimitin (avimitin) - Wednesday, 01 November 2023, 12:31 GMT
Yes you are right. This is my mistake. We don't need those ARM build.
Comment by Robin Candau (Antiz) - Wednesday, 01 November 2023, 13:28 GMT
Alright, I rebuilt the package with `make dist-frontend` and `make dist-backend-linux` in v4.4.3-2: https://gitlab.archlinux.org/archlinux/packaging/packages/grafana-zabbix/-/commit/85822a20c825d197e6675a97f05d5a48b89a1768
It would be great if you could test it to make sure everything works as intended :)

It is currently in [extra-testing], but if you do not have a running install using the testing repositories, you can grab the package via the following link and install it locally (pacman -U grafana-zabbix-4.4.3-2-any.pkg.tar.zst)
https://archlinux.org/packages/extra-testing/any/grafana-zabbix/download/
There are no {make,}dependencies for it currently in the testing repositories so there's no risk of partial upgrade ;)

Thanks in advance!
Comment by Robin Candau (Antiz) - Friday, 10 November 2023, 08:44 GMT
Have you had the opportunity to test the new package yet?
Comment by avimitin (avimitin) - Friday, 10 November 2023, 09:03 GMT
Sorry for the late response. I am busy these days so I don't have an opportunity to test it.

Loading...