FS#73948 - networkmanager 1.36.0 breaks DSL connection

Attached to Project: Arch Linux
Opened by Xingang Li (smsxgli) - Friday, 25 February 2022, 08:58 GMT
Last edited by Jan Alexander Steffens (heftig) - Tuesday, 22 March 2022, 23:36 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Architecture x86_64
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
After recent updating with networkmanager and libnm to 1.36.0-1, I cannot set up my DSL connection.
output of `nmcli connection up DSL` (`DSL` is my the DSL connection's name):
```
Error: Connection activation failed: The device could not be readied for configuration
Hint: use 'journalctl -xe NM_CONNECTION=7caf4a0b-82bd-4d54-9d1b-40d93d20fdb0 + NM_DEVICE=eno1' to get more details.
```
Downgrade both two of them to 1.34.0 solve this problem and I can set up my DSL connection again.

Additional info:
* package version(s) networkmanager: 1.36.0-1; libnm: 1.36.0-1.
* config and/or log files etc. The attached file is the output of `journalctl -xe NM_CONNECTION=7caf4a0b-82bd-4d54-9d1b-40d93d20fdb0 + NM_DEVICE=eno1`
* link to upstream bug report, if any

Steps to reproduce:
upgrade networkmanager and libnm to 1.36.0-1, restart NetworkManager.service, then connect to a SDL connection.
   error_log.txt (8.8 KiB)
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Tuesday, 22 March 2022, 23:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.36.4
Comment by Francesco Alesii (francesco_archlinux) - Saturday, 26 February 2022, 08:09 GMT
Hi guys,

after updating the packages "networkmanager" and "libnm" from version 1.34 to version 1.36, the file "resolv.conf" is empty.
Here the "resolv.conf" file created on my PC:
"
# Generated by NetworkManager
search --
"

Downgrading both the packages to version 1.34 does fix the issue.

Francesco
Comment by Jan Alexander Steffens (heftig) - Saturday, 26 February 2022, 14:19 GMT
Please file this upstream.
Comment by Xingang Li (smsxgli) - Sunday, 27 February 2022, 04:59 GMT
OK.
Comment by Alexey (November) - Sunday, 27 February 2022, 09:40 GMT
Encountered the same problem today after updating from 1.34 to 1.36
Comment by Xingang Li (smsxgli) - Sunday, 27 February 2022, 14:41 GMT
The upstream issue that I opened: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/940. Welcome to add your detail description there.
Comment by Philip Müller (philm) - Wednesday, 16 March 2022, 04:55 GMT
this might improve things: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1148
Comment by Marcell Meszaros (MarsSeed) - Wednesday, 16 March 2022, 15:26 GMT
Upstream issue for above mentioned MR !1148:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/954

The MR commits have already been cherry-picked to 'nm-1-36' branch:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/compare/2e4d1e8d...6e02ab13
Comment by Jan Alexander Steffens (heftig) - Wednesday, 16 March 2022, 15:42 GMT
Even though there's a workaround available, is this painful enough to advance the networkmanager package to the branch head?
Comment by Marcell Meszaros (MarsSeed) - Wednesday, 16 March 2022, 16:27 GMT
@heftig I don't have the expertise to decide that.
Though you could try selective patching (cherry-picking the commits directly).

I am unaffected by the issue as I don't use DSL/PPPoE.

I can only verify that on Manjaro unstable branch,
using @philm's patched rebuild networkmanager-1.36.2-1.0-x86_64
works as well as the latest Arch binary for non-DSL, non-PPPoE usage.
Comment by Marcell Meszaros (MarsSeed) - Wednesday, 16 March 2022, 16:34 GMT
@philm could you please post a link to your PKGBUILD
for Manjaro's networkmanager-1.36.2-1.0-x86_64?

It seems I can't find that package version's source on the interwebs. :)
Comment by Marcell Meszaros (MarsSeed) - Wednesday, 16 March 2022, 16:45 GMT
@heftig there don't seem to be too many changes yet on 'nm-1-36' branch head.

There are a few other hotfixes that might even be useful.

Comparison between release tag '1.36.2' and current branch head of 'nm-1-36':
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/compare/1.36.2...6e02ab13
Comment by Philip Müller (philm) - Wednesday, 16 March 2022, 18:40 GMT
I added not much to the PKGBUILD, just the MR. However going to head of nm-1-36 would makes sense as it will be included in 1.36.4 at some point anyway ...
   diff (1.2 KiB)
Comment by Marcell Meszaros (MarsSeed) - Tuesday, 22 March 2022, 22:55 GMT
[networkmanager] 1.36.4 is in [extra], shipping the official PPPoE/DSL fixes:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.36.4/NEWS

===============================================
NetworkManager-1.36.4
===============================================

* The internal DHCPv4 client now discards NAKs packets coming
from servers different from the one that sent the offer.
* Fix activation of PPPoE connections with "pppoe.parent" unset.
* Fix potential libnm crash when the client object initialization gets
canceled.
* Other various fixes and improvements.

Loading...