FS#73430 - pass-otp: Package version does not match source code version

Attached to Project: Community Packages
Opened by Janis König (LeonardK) - Thursday, 20 January 2022, 11:40 GMT
Last edited by Toolybird (Toolybird) - Wednesday, 17 May 2023, 03:42 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Morten Linderud (Foxboron)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: The package version is 1.2.0, however, if we extract the archive, we see it's still 1.1.0.

Additional info:
* package version(s): 1.2.0

Steps to reproduce:

$ wget -O - https://archlinux.org/packages/community/any/pass-otp/download 2>/dev/null | \
zstdcat | \
tar -Ox usr/lib/password-store/extensions/otp.bash | \
grep ^VERSION
VERSION="1.1.1"
This task depends upon

Closed by  Toolybird (Toolybird)
Wednesday, 17 May 2023, 03:42 GMT
Reason for closing:  Upstream
Additional comments about closing:  Definitely an upstream issue. Please follow up there.
Comment by Janis König (LeonardK) - Thursday, 20 January 2022, 11:43 GMT
Note that the update to 1.2.0 also added the Perl module Pass::OTP aka 'otptool' as an optional dependency which would take precedence over the default otpauth. This is required for Steam OTP codes: https://github.com/tadfisher/pass-otp/issues/97
Comment by Doug Newgard (Scimmia) - Thursday, 20 January 2022, 11:50 GMT
Check the upstream repo, not only was this how they shipped 1.2.0, but it's currently showing 1.1.2 in the default branch.
Comment by Levente Polyak (anthraxx) - Thursday, 20 January 2022, 11:55 GMT
That is correct from the packaging perspective and is version 1.2.0. The label has not been increased upstream before v1.2.0:
https://github.com/tadfisher/pass-otp/blob/v1.2.0/otp.bash#L19
https://github.com/tadfisher/pass-otp/commit/0aadd4c82cf190ae8ac9c08e7eb142716ed33a85
Comment by Janis König (LeonardK) - Thursday, 20 January 2022, 13:30 GMT
Oh this is confusing. So

| git tag | VERSION | remark |
| 1.1.0 | 1.1.0 | |
| 1.2.0 | 1.1.1 | |
| -- | 1.1.2 | Add support for using Pass::OTP |

This is quite unfortunate, but I guess should be fixed upstream "first"? Probably the least invasive change would be to jump to 1.3/1.3.0 in both git tag was well as VERSION.

Loading...