FS#71566 - [f2fs-tools] f2fs_io is missing

Attached to Project: Arch Linux
Opened by ketsui (ketsui) - Wednesday, 21 July 2021, 06:18 GMT
Last edited by Christian Hesse (eworm) - Thursday, 22 July 2021, 07:08 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Tobias Powalowski (tpowa)
Christian Hesse (eworm)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
The command f2fs_io doesn't end up in the resulting package because of this line in the f2fs-tools PKGBUILD:

sed -i '/sg_write_buffer/d' tools/Makefile.am

this deletes this line in tools/Makefile.am completely:

SUBDIRS = sg_write_buffer f2fs_io

Please fix this collateral damage.
This task depends upon

Closed by  Christian Hesse (eworm)
Thursday, 22 July 2021, 07:08 GMT
Reason for closing:  Fixed
Additional comments about closing:  f2fs-tools 1.14.0-2
Comment by ketsui (ketsui) - Wednesday, 21 July 2021, 06:46 GMT
If the intent of that line was to remove the file sg_write_buffer from the resulting package perhaps it's better to delete it from $pkgdir instead of editing makefiles which could result in unintended consequences like this.

Loading...