FS#69445 - [tor] Recompilation needed for zstd 1.4.8-1

Attached to Project: Community Packages
Opened by mpan (mpan) - Tuesday, 26 January 2021, 15:37 GMT
Last edited by Levente Polyak (anthraxx) - Wednesday, 10 March 2021, 23:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Package tor 0.4.4.6-1 has been built with zstd 1.4.5, in Nov 2020. In Jan 2021 zstd has been updated to 1.4.8, but the tor package hasn’t been rebuilt.

The Tor relay detects the difference between the build-time and the runtime versions and disables zstd altogether. From tor logs:
---
Tor was compiled with zstd 1.4.5, but is running with zstd 1.4.8. For safety, we'll avoid using advanced zstd functionality.
---
This task depends upon

Closed by  Levente Polyak (anthraxx)
Wednesday, 10 March 2021, 23:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.4.5.6-1
Comment by Emil (xexaxo) - Tuesday, 26 January 2021, 15:58 GMT
Fwiw libzstd.so did not change the SONAME, so existing uses should just work without a rebuild.
Hopefully zstd did not break the ABI - I did not check.
Comment by mpan (mpan) - Tuesday, 26 January 2021, 20:27 GMT
It’s not about ABI. Tor performs an explicit test by itself. In `tor_zstd_can_use_static_apis`⁽¹⁾. If there is a version mismatch, it prints a warning⁽²⁾ and then doesn’t use some of the zstd features (note: my initial “altogether” was not right).
____
⁽¹⁾ https://github.com/torproject/tor/blob/4f114f59e62397fba98b17e1394adfa29e3de78b/src/lib/compress/compress_zstd.c#L127
⁽²⁾ https://github.com/torproject/tor/blob/4f114f59e62397fba98b17e1394adfa29e3de78b/src/lib/compress/compress_zstd.c#L525
Comment by Emil (xexaxo) - Friday, 29 January 2021, 00:09 GMT
Thanks for the correction and sorry for misreading it the first time.

Fwiw the only way I see this handled (note I'm not a TU) is an explicit version in the depends array "zstd=1.4.8". HTH
Comment by Levente Polyak (anthraxx) - Friday, 29 January 2021, 00:54 GMT
thats actually a pretty horrible hack they have implemented for using unstable API.
Comment by ilf (ilf) - Tuesday, 23 February 2021, 12:12 GMT
I appreciate the work of the packagers and maintainers, and I don't want to nag.

It has been a month though, with two new upstream releases: 0.4.4.7 on 02-03, and 0.4.5.6 on 02-15, the package is flagged out-of-date since 01-12.
It would be really great to get the Arch package upgraded to the new release and rebuilt for the new system libraries.

Thanks, and keep up the good work!

Loading...