FS#69365 - [youtube-dl] python-setuptools to makedepends

Attached to Project: Community Packages
Opened by Geert Hendrickx (ghen) - Tuesday, 19 January 2021, 09:38 GMT
Last edited by Daniel M. Capella (polyzen) - Wednesday, 21 April 2021, 20:08 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jaroslav Lichtblau (Dragonlord)
Daniel M. Capella (polyzen)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
python-setuptools is a runtime dependency for youtube-dl per bug  FS#37544 ,
But this seems no longer needed; it is not needed at runtime and optional at buildtime, so it can either be moved to makedepends or removed completetly.

Steps to reproduce:
I tested two scenarios:

1/ Run the current youtube-dl 2021.01.16-1 package (built with python-setuptools) but without python-setuptools installed, using pacman --assume-installed python-setuptools.
Succesfully downloaded a few videos from different sites.

2/ Build the package without python-setuptools in either depends or makedepends, and perform the same runtime tests.
The resulting package is built a bit differently, but is functionally identical. From src/youtube-dl/setup.py:

try:
from setuptools import setup, Command
setuptools_available = True
except ImportError:
from distutils.core import setup, Command
setuptools_available = False
from distutils.spawn import spawn

So probably best to keep python-setup as makedepends (but not as runtime depends).
This task depends upon

Closed by  Daniel M. Capella (polyzen)
Wednesday, 21 April 2021, 20:08 GMT
Reason for closing:  Implemented
Additional comments about closing:  https://github.com/archlinux/svntogit-co mmunity/commit/0c57ae0d702a7a3b6907223fd 86f68d3e7ebe854#diff-3e341d2d9c67be01819 b25b25d5e53ea3cdf3a38d28846cda85a195eb9b 7203a

Loading...