FS#67824 - [openimageio] Should use arch provided fmtlib and pugixml instead of its own
Attached to Project:
Community Packages
Opened by Patrick Northon (patlefort) - Thursday, 03 September 2020, 22:11 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Friday, 04 September 2020, 20:19 GMT
Opened by Patrick Northon (patlefort) - Thursday, 03 September 2020, 22:11 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Friday, 04 September 2020, 20:19 GMT
|
Details
Description:
The current openimageio package build its own fmtlib and cause conflicts if you try to use fmtlib and openimageio in your own project because openimageio will pull its fmt dependency on top. The fix is simple: add -DBUILD_MISSING_FMT=OFF to the cmake build options and add fmt as a dependency. As for pugixml, the same could be done with -DUSE_EXTERNAL_PUGIXML=ON, however it does not work currently and I made a pull request upstream (https://github.com/OpenImageIO/oiio/pull/2698) to make it work. Additional info: openimageio 2.1.19.0-1 Upstream pull request: https://github.com/OpenImageIO/oiio/pull/2698 |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Friday, 04 September 2020, 20:19 GMT
Reason for closing: Fixed
Friday, 04 September 2020, 20:19 GMT
Reason for closing: Fixed
Comment by
Eli Schwartz (eschwartz) -
Thursday, 03 September 2020, 22:56 GMT
Comment by
Sven-Hendrik Haase (Svenstaro) -
Friday, 04 September 2020, 15:41 GMT
Comment by
Patrick Northon (patlefort) -
Friday, 04 September 2020, 20:03 GMT
Comment by
Sven-Hendrik Haase (Svenstaro) -
Friday, 04 September 2020, 20:19 GMT
It also "git clone"s
https://github.com/Tessil/robin-map
(
https://repology.org/project/robin-map/versions
) and pybind11 during the cmake configure stage (in addition to
fmtlib). These should be devendored too...
I added 2.1.19.0-2 to [community-testing] with the suggested
changes. Please have a look.
Like Eli said, it would be good to do the same with robin-map with
option -DBUILD_MISSING_ROBINMAP=OFF. For pybind11, it should be
fine as is. It is supposed to find and use the system one if it
exists. That aside, it's looking good.
I checked the compile time output and I believe we don't need
-DBUILD_MISSING_ROBINMAP=OFF. Also, I took removed git from the
makedeps and nothing failed during build time so I believe we're
good.