FS#67098 - [intltool] latest patch for race condition breaks some builds

Attached to Project: Arch Linux
Opened by Skunnyk (Skunnyk) - Wednesday, 24 June 2020, 20:43 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Jelle van der Waa (jelly)
Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:

intltool from version 0.50.0-6 (with this patch : https://git.archlinux.org/svntogit/packages.git/tree/trunk/intltool-fixrace.patch?h=packages/intltool) introduce the creation of a lock file toi avoid some race conditions.
However it seems that this lock file is not removed correctly every time

Additional info:
* 0.51.0-6

Steps to reproduce:


$ git clone https://gitlab.xfce.org/xfce/libxfce4ui
$ cd libxfce4ui
$ ./autogen.sh && make distcheck
[...]

ERROR: files left in build directory after distclean:
./po/.intltool-merge-cache.lock
make[1]: *** [Makefile:825: distcleancheck] Error 1

Reverting back to 0.51.0-5 and I can't reproduce the problem.
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:16 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/intltool/issues/1
Comment by Mateusz Gozdek (invidian) - Thursday, 08 April 2021, 17:39 GMT
Created a merge request to fix this as it also affects other XFCE packages. https://code.launchpad.net/~invidian/intltool/fix-dangling-lock-file/+merge/400825

I'm not sure how to confirm it does not make a regression to the races for which lock was originally added, so some extra testing should be done.
Comment by Jelle van der Waa (jelly) - Saturday, 22 July 2023, 13:46 GMT
The proposed patch does not seem to be accepted upstream, so there is currently no solution.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...