FS#65957 - [riot-desktop] should depend on electron7
Attached to Project:
Community Packages
Opened by Paul Melis (paulmelis) - Tuesday, 24 March 2020, 10:20 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Sunday, 24 May 2020, 21:45 GMT
Opened by Paul Melis (paulmelis) - Tuesday, 24 March 2020, 10:20 GMT
Last edited by Bruno Pagani (ArchangeGabriel) - Sunday, 24 May 2020, 21:45 GMT
|
Details
Description:
While trying to debug an issue (see below) with single-sign on in riot-desktop 1.5.12 it appears that the package depends on the electron package, which is currently at version 8. But riot-desktop should actually build against electron version 7, see https://github.com/vector-im/riot-web/blob/6e68c106f724e536b783685411ded2590a2e63f1/package.json#L156. I assume the riot-desktop build actually uses the global electron installation and does not download its own version, but I don't know enough about electron builds to be sure. Additional info: * See https://github.com/vector-im/riot-web/issues/12830 for more information. * This is with riot-desktop 1.5.12 |
This task depends upon
Closed by Bruno Pagani (ArchangeGabriel)
Sunday, 24 May 2020, 21:45 GMT
Reason for closing: Fixed
Additional comments about closing: Ended up being FS#66324 .
Sunday, 24 May 2020, 21:45 GMT
Reason for closing: Fixed
Additional comments about closing: Ended up being
https://bugs.archlinux.org/task/65714
As stated in the bugs, riot itself is distributed with electron 7 again. And I would prefer this for the archlinux package too,
the system tray icon is the reason I am using riot-desktop, without it, the package isn't useful at all, because there is no
real other difference to the browser version.
That isn't clear, although the Riot dev in the linked issue does hint in that direction.