Arch Linux

I agree that this is an issue. Any suggestions? Should we automatically disable all notifications once an account is suspended?

FWIW, I disabled all notifications on your account.

Thank you. I think it should disable all notifications and let the user know it has been like that.

Agreed. Working on a patch.

Does a user currently get notified somehow when they're suspended? I'm having trouble finding a path to that.

You only get notified when you try to log in, and then the interface rejects you.

You meaning me. I will get my revenge.

Wait a sec, you're not actually getting notifications regarding packages, nor anything like that, but when trying to login to your suspended account on the AUR? That's a problem, indeed, and a funny one. Also, what is this nonsense of revenge?

I don't believe so, grazzolini. The PackageNotification records still exist for a suspended user, so whenever something updates on a package they were previously being notified on, it goes through it's normal process and sends the message. The notification I was asking about was in consideration of "let the user know it has been like that." I suppose we could add some more details to the account suspended message on login, but it seems a bit flimsy to only notify them in that case.

Edit: https://lists.archlinux.org/pipermail/aur-dev/2020-July/004915.html removes the user being suspended from the PackageNotification table completely. It doesn't go beyond and notify the user atm.

Patch is a bit heavy handed, though. Looking more into this.

I receive the notifications from the packages, but I didn't receive any notification when the account was suspended.

I seem to recall you received extensive notifications before, during, and after your suspension.

As represented by the conversations with multiple TUs.

(I agree there was no aurweb notification that you were suspended, but that's generally handled by the responsible TU directly emailing you.)

I'm working on a patch now that doesn't disturb the PackageNotifications table; instead, it just checks to see if you're suspended or not before sending out the notification...

Fair warning, statements like "I will get my revenge." will get you banned here as well

```
action_map = {
'send-resetkey': ResetKeyNotification,
'welcome': WelcomeNotification,
'comment': CommentNotification,
'update': UpdateNotification,
'flag': FlagNotification,
'adopt': AdoptNotification,
'disown': DisownNotification,
'comaintainer-add': ComaintainerAddNotification,
'comaintainer-remove': ComaintainerRemoveNotification,
'delete': DeleteNotification,
'request-open': RequestOpenNotification,
'request-close': RequestCloseNotification,
'tu-vote-reminder': TUVoteReminderNotification,
}
```

Out of these, any notifications we want to preserve while suspended?

PS: As far as I can tell in the `aurweb-notify` code, any user that's associated ends up getting notified, regardless of being suspended. The fix here is to add an extra WHERE clause to each notification we want to silence: `Users.Suspended = 0`.

Alright, here we are: https://lists.archlinux.org/pipermail/aur-dev/2020-July/004917.html

I don't think there are any notifications worth sending while the account is suspended.

Alright, follow-up patch sent that doesn't send anything to suspended users.

Sorry for that back and forth -- was focusing too high level at first.

merged into aurweb branch `pu`.