FS#61380 - [tpm2-tools] Tests are not enabled

Attached to Project: Community Packages
Opened by Jonas Witschel (diabonas) - Sunday, 13 January 2019, 12:50 GMT
Last edited by Morten Linderud (Foxboron) - Sunday, 13 January 2019, 13:19 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To No-one
Architecture x86_64
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

tpm2-tools 3.1.3-1 includes a check() function that doesn't actually do anything: to enable unit tests, ./configure has to be called with the "--enable-unit" option.

On the other hand, the checkdepends "tpm2-abrmd" and "python-pyaml" are unnecessary for tpm2-tools version 3.X as they are only used for the system tests, not for the unit tests. The system tests are not run automatically by "make check", you have to invoke them manually, see https://github.com/tpm2-software/tpm2-tools/blob/3.X/test/system/README.md To do so, you need to start and configure your own tpm_server (from ibm-sw-tpm2), which is quite a laborious job in this version of tpm2-tools. (The current development version already has this automated, see the tpm2-tools-git AUR package.)

Steps to reproduce:
Running makepkg on the package gives 0 tests in total in the output of the "Testsuite summary". Adding "--enable-unit" to ./configure gives 10 passing tests instead.
This task depends upon

Closed by  Morten Linderud (Foxboron)
Sunday, 13 January 2019, 13:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  3.1.3-2
Comment by Morten Linderud (Foxboron) - Sunday, 13 January 2019, 13:19 GMT
Thanks!

The AUR package is a bit wierd as it runs configure twice. Should only be run once in `build()`. But the rest of it has been noted and updates.

Loading...