FS#59652 - [libappindicator] Needs to have its Plasma patch dropped
Attached to Project:
Community Packages
Opened by Sebastian Krzyszkowiak (dos) - Tuesday, 14 August 2018, 00:23 GMT
Last edited by Balló György (City-busz) - Monday, 16 March 2020, 08:00 GMT
Opened by Sebastian Krzyszkowiak (dos) - Tuesday, 14 August 2018, 00:23 GMT
Last edited by Balló György (City-busz) - Monday, 16 March 2020, 08:00 GMT
|
Details
My patch for libappindicator - improved-plasma.patch - needs
to be dropped, as with recent Plasma versions it actually
breaks stuff instead of fixing it, resulting in non-working
left click on the tray icon.
Now Plasma can detect the case this patch was fixing by itself and does the job just fine, while something in GTK+ has changed and libappindicator's way to show menu this patch uses doesn't work anymore. This applies to libappindicator 12.10.0-12 (BTW. It seems it also fails to build from source now. I had to remove -Werror to fix this, although I haven't used clean chroot to confirm, so just adding it here as a BTW) |
This task depends upon
Closed by Balló György (City-busz)
Monday, 16 March 2020, 08:00 GMT
Reason for closing: Fixed
Additional comments about closing: libappindicator 12.10.0-14
Monday, 16 March 2020, 08:00 GMT
Reason for closing: Fixed
Additional comments about closing: libappindicator 12.10.0-14
While we are at it, shouldn’t we just move to actual Ayatana indicators? The descriptions of our packages mention that name, but our packages are not Ayatana ones, that are in AUR. Haven’t have the time to try them yet, but I’ve heard they are way better (and still developed AFAICS, while the last release here is 2012…).
But yeah, it would be good to move to Ayatana indicators.
It might not be the same for other apps, and in any case we agree that when it comes to libappindicator only, the patch should be removed.
Also, Chromium's code does not even provide any way to react to Activate signal from app indicators, so it's entirely up to them to support anything else than right-click action.
But keep in mind that Chromium is going to require libappindicator and remove the other GTK-based codepath anyway, as it's already marked as deprecated, so in the long run it's in everyone's best interest to make lib(ayatana-)appindicator work well instead of relying on whatever you get when you don't have it installed.