FS#58635 - [edk2-ovmf] request to additionally package the OVMF.fd file (unsplit code + vars)
Attached to Project:
Arch Linux
Opened by John Thomson (johnth) - Thursday, 17 May 2018, 11:37 GMT
Last edited by David Runge (dvzrv) - Sunday, 03 May 2020, 13:36 GMT
Opened by John Thomson (johnth) - Thursday, 17 May 2018, 11:37 GMT
Last edited by David Runge (dvzrv) - Sunday, 03 May 2020, 13:36 GMT
|
Details
Xen cannot use the separate OVMF code and vars files, and
requires the unsplit OVMF.fd file.
This is built by OVMF, but not included in the Arch Linux package. Could this file be included in a split package, or the main package? My approach is here: https://gitlab.com/archlinux-packages-johnth/packages-modified/compare/packages%2Fovmf...modified%2Fovmf-split Cheers |
This task depends upon
Closed by David Runge (dvzrv)
Sunday, 03 May 2020, 13:36 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with edk2-ovmf 202002-7
Sunday, 03 May 2020, 13:36 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with edk2-ovmf 202002-7
Do I understand correctly that unsplit package is the same as the current OVMF but *does not* include OVMF_VARS.fd?
My intent was:
normal package is unchanged
unsplit package includes ovmf.fd, where the vars.fd data is included in the ovmf.fd file
I will have another look over svntogit to recheck.
"${srcdir}"/edk2-${_edk2_tag}/Build/OvmfX64/RELEASE_${_toolchain_opt}/FV/OVMF.fd
I thought the cleanest and smallest way would be to include this file in an additional (pkgbuild split) package.
Open to any suggestions or changes.
Cheers!
Could you please expand more on it? I am looking at your package and I see that only OVMF.fd included. The package does not copy/concat VARS.fd file at all. So home come VARS is included in OVMF?
> The package does not copy/concat VARS.fd file at all
This is done by the OVMF build system for OVMF.fd
https://github.com/tianocore/edk2/blob/1f3b1eb3082206e4efc4091982a208022b86c7ca/OvmfPkg/OvmfPkgX64.fdf#L17
https://github.com/tianocore/edk2/commit/1c50db8adaf9d5ce071e27a518a46cd363ac5efe
Rebuilding the whole package just to concat two files seems overkill. Is there any reason why OVMF.fd cannot be included in addition to split files? i.e. ovmf would provide 3 files: OVMF.fd OVMF_CODE.fd OVMF_VARS.fd. Is there any drawback in doing this?
Manually installed the [testing] package.
Tested x64 OVMF.fd with Xen HVM boot to firmware, and Xen HVM boot to linux with populated /sys/firmware/efi/efivars/
I am happy to wait if you want more feedback?
Cheers
Tested both the old symlink, and new location.
/usr/share/ovmf/x64/OVMF.fd
/usr/share/edk2-ovmf/x64/OVMF.fd
Tested booting to OVMF UEFI shell, and linux with populated /sys/firmware/efi
Cheers