FS#58635 - [edk2-ovmf] request to additionally package the OVMF.fd file (unsplit code + vars)

Attached to Project: Arch Linux
Opened by John Thomson (johnth) - Thursday, 17 May 2018, 11:37 GMT
Last edited by David Runge (dvzrv) - Sunday, 03 May 2020, 13:36 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Thomas Bächler (brain0)
Anatol Pomozov (anatolik)
David Runge (dvzrv)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Xen cannot use the separate OVMF code and vars files, and requires the unsplit OVMF.fd file.
This is built by OVMF, but not included in the Arch Linux package.

Could this file be included in a split package, or the main package?

My approach is here:
https://gitlab.com/archlinux-packages-johnth/packages-modified/compare/packages%2Fovmf...modified%2Fovmf-split

Cheers
This task depends upon

Closed by  David Runge (dvzrv)
Sunday, 03 May 2020, 13:36 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with edk2-ovmf 202002-7
Comment by Filipe Laíns (FFY00) - Thursday, 05 March 2020, 19:43 GMT
I am planning to move xen to [community]. Could this be fixed?
Comment by Anatol Pomozov (anatolik) - Thursday, 05 March 2020, 19:48 GMT
John, in your package you use DEBUG build. Why do you do it?

Do I understand correctly that unsplit package is the same as the current OVMF but *does not* include OVMF_VARS.fd?
Comment by John Thomson (johnth) - Thursday, 05 March 2020, 19:51 GMT
No need for the DEBUG build.

My intent was:
normal package is unchanged

unsplit package includes ovmf.fd, where the vars.fd data is included in the ovmf.fd file

I will have another look over svntogit to recheck.
Comment by John Thomson (johnth) - Thursday, 05 March 2020, 19:59 GMT
Yes, wanting this file packaged:
"${srcdir}"/edk2-${_edk2_tag}/Build/OvmfX64/RELEASE_${_toolchain_opt}/FV/OVMF.fd

I thought the cleanest and smallest way would be to include this file in an additional (pkgbuild split) package.
Open to any suggestions or changes.

Cheers!
Comment by Anatol Pomozov (anatolik) - Thursday, 05 March 2020, 20:05 GMT
> where the vars.fd data is included in the ovmf.fd file

Could you please expand more on it? I am looking at your package and I see that only OVMF.fd included. The package does not copy/concat VARS.fd file at all. So home come VARS is included in OVMF?
Comment by John Thomson (johnth) - Thursday, 05 March 2020, 21:12 GMT
Yes,

> The package does not copy/concat VARS.fd file at all

This is done by the OVMF build system for OVMF.fd

https://github.com/tianocore/edk2/blob/1f3b1eb3082206e4efc4091982a208022b86c7ca/OvmfPkg/OvmfPkgX64.fdf#L17
https://github.com/tianocore/edk2/commit/1c50db8adaf9d5ce071e27a518a46cd363ac5efe
Comment by Anatol Pomozov (anatolik) - Sunday, 08 March 2020, 02:39 GMT
Ah got it. OVMF is essentially OVMF_CODE+OVMF_VARS combined together.

Rebuilding the whole package just to concat two files seems overkill. Is there any reason why OVMF.fd cannot be included in addition to split files? i.e. ovmf would provide 3 files: OVMF.fd OVMF_CODE.fd OVMF_VARS.fd. Is there any drawback in doing this?
Comment by Anatol Pomozov (anatolik) - Sunday, 08 March 2020, 03:17 GMT
I just pushed ovmf-1:202002 with additional non-split OVMF file to [testing] for your convenience. Please install it and verify that it works for you. Let me know if you see any issues with Xen.
Comment by John Thomson (johnth) - Sunday, 08 March 2020, 07:47 GMT
Yes, that worked fine for me, thanks.

Manually installed the [testing] package.
Tested x64 OVMF.fd with Xen HVM boot to firmware, and Xen HVM boot to linux with populated /sys/firmware/efi/efivars/
I am happy to wait if you want more feedback?

Cheers
Comment by David Runge (dvzrv) - Wednesday, 22 April 2020, 12:45 GMT
@johnth: Please check whether this is still okay with edk2-ovmf 202002-6 in [testing] (it will replace ovmf).
Comment by John Thomson (johnth) - Wednesday, 22 April 2020, 21:15 GMT
Yes, edk2-ovmf in testing includes an OVMF.fd, and it worked fine for me with Xen.

Tested both the old symlink, and new location.
/usr/share/ovmf/x64/OVMF.fd
/usr/share/edk2-ovmf/x64/OVMF.fd

Tested booting to OVMF UEFI shell, and linux with populated /sys/firmware/efi

Cheers
Comment by David Runge (dvzrv) - Thursday, 23 April 2020, 09:40 GMT
@johnth: Thanks for testing! :)

Loading...