FS#57616 - [vlc] Do not remove implicit-function-declaration (patch provided)

Attached to Project: Arch Linux
Opened by Benjamin Robin (benjarobin) - Friday, 23 February 2018, 19:17 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:27 GMT
Task Type General Gripe
Category Packages: Testing
Status Closed
Assigned To David Runge (dvzrv)
Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No



The PKGBUILD of VLC 3.0 patch the ./configure and remove -Werror-implicit-function-declaration
This warning can be fix differently and more nicely

Additional info:
* package version(s) : vlc 3.0.0-1 staging


sed -e 's|-Werror-implicit-function-declaration||g' -i configure


sed -e 's|FRIBIDI_NO_DEPRECATED|FRIBIDI_DEPRECATED|g' -i modules/text_renderer/freetype/text_layout.c
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:27 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/vlc/issues/4
Comment by Levente Polyak (anthraxx) - Friday, 23 February 2018, 19:27 GMT
Can you be more verbose about why FRIBIDI_DEPRECATED should be used in text_layout.c?
Comment by Jan de Groot (JGC) - Friday, 23 February 2018, 19:47 GMT
vlc uses a deprecated function that is not declared without FRIBIDI_DEPRECATED. GCC warns about this. I think it's better to fix a warning instead of hiding it.
Comment by Benjamin Robin (benjarobin) - Friday, 23 February 2018, 20:19 GMT
Technically FRIBIDI_DEPRECATED does nothing, this is just a good unique name in order to replace FRIBIDI_NO_DEPRECATED.
But if you declare FRIBIDI_NO_DEPRECATED it will not include "fribidi-deprecated.h" from "fribidi.h"
Comment by Eli Schwartz (eschwartz) - Friday, 23 February 2018, 20:52 GMT
-Werror is a filthy, disgusting habit and the upstream developers should be reprimanded for using it in release archives. Providing a warning is one thing, as is using -Werror via environment CFLAGS for testing purposes, for example using Travis environment variables. Breaking downstream builds by distro developers or just random users, because the project uses -Werror without actually fixing warnings, is pretty stupid.

We're not "hiding" warnings. Warnings are, well, warnings. They exist to be looked at in build logs. Error-on-warnings is only useful in a very strictly limited situation, that being a desire to get immediate alerts when warnings exist, for development purposes.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.