FS#5623 - Inconsistency in /usr/share/licenses directory

Attached to Project: Arch Linux
Opened by Michal Krenek (Mikos) - Thursday, 19 October 2006, 12:29 GMT
Last edited by Greg (dolby) - Wednesday, 23 July 2008, 21:13 GMT
Task Type Bug Report
Category System
Status Closed
Assigned To Thomas Bächler (brain0)
Architecture All
Severity Low
Priority Normal
Reported Version 0.7.2 Gimmick
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Some packages installs custom licenses directly to subdirectories in /usr/share/licenses (for example nvidia-utils, boost, conky). Other packages installs custom licenses to subdirectories in /usr/share/licenses/custom (for example opera, unrar, ipython, divx4linux, ttf-bitstream-vera, ttf-dejavu). This is very bad inconsistency. What is the right option for custom luicenses - /usr/share/licenses or /usr/share/licenses/custom? Only one location should be chosen and all packages should use only that one. Bad packages (which uses bad location) should be fixed and rebuilt as soon as possible.
This task depends upon

Closed by  Greg (dolby)
Wednesday, 23 July 2008, 21:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  Closing as flashplayer-standalone was removed from repos. If you know another package that still has that problem feel free to ask for a reopening.
Comment by Jens Adam (byte) - Friday, 20 October 2006, 02:41 GMT
While it's certainly not high priority, I noticed that too. Found it a bit irritating when I assembled my first PKGBUILD and couldn't really agree on one or the other.
Comment by Roman Kyrylych (Romashka) - Friday, 20 October 2006, 08:21 GMT
I've noticed that too. IMHO all custom licenses should be installed right into /usr/share/licenses
Comment by Judd Vinet (judd) - Sunday, 12 November 2006, 23:33 GMT
From the makepkg manpage:

This field specifies the license(s) that apply to
the package. Commonly-used licenses are typically
found in /usr/share/licenses/common. If you see
the package's license there, simply reference it
in the license field (eg, license="GPL"). If the
package provides a license not found in
/usr/share/licenses/common, then you should
include the license in the package itself and set
license="custom" or license="custom:LicenseName".
The license itself should be placed in a directory
called $startdir/pkg/usr/share/licenses/$pkgname.

If multiple licenses are applied, use the array
form: licenses=('GPL' 'FDL')
Comment by Judd Vinet (judd) - Sunday, 12 November 2006, 23:33 GMT
So custom licenses should be in /usr/share/licenses/$pkgname
Comment by Roman Kyrylych (Romashka) - Monday, 13 November 2006, 10:49 GMT
So all packages that place licenses in /usr/share/licenses/custom/$pkgname should be fixed.
On my machine these are ttf-bitsream-vera, ttf-dejavu and unrar (custom/rarsoft !).

Also, some of files are named license.txt, others LICENSE.
Comment by Jens Adam (byte) - Tuesday, 14 November 2006, 01:23 GMT
find /var/abs/ -name PKGBUILD | xargs grep licenses/custom | sed 's|/PKGBUILD.*||' | sort | uniq

I'd say just name the file like the original.
Comment by Fredrik (vEX) - Monday, 08 October 2007, 17:49 GMT
Some licenses are still placed in the wrong directory:

$ pacman -Qo /usr/share/licenses/LEGAL.NOTICE
/usr/share/licenses/LEGAL.NOTICE is owned by file 4.21-2

$ ls /usr/share/licenses/custom/
openssh ttf-bitstream-vera

$ pacman -Q openssh ttf-bitstream-vera
openssh 4.7p1-1
ttf-bitstream-vera 1.10-5
Comment by Aaron Griffin (phrakture) - Tuesday, 09 October 2007, 16:41 GMT
Added Andy for file and bitstream.

I can get openssh later too unless you want to do it.
Comment by Jens Adam (byte) - Monday, 03 December 2007, 02:46 GMT
openssh is currently in testing, so how about killing it off this list?
Comment by Aaron Griffin (phrakture) - Monday, 03 December 2007, 18:16 GMT
Sorry 'bout that - I committed the change to CVS and will pick it up on the next build (I don't believe it warrants a rebuild right now, due to the fact that we don't actually DO anything with the license field just yet)
Comment by Fredrik (vEX) - Monday, 21 January 2008, 22:05 GMT
With the new ttf-dejavu package (2.23-1) all files in my /usr/share/licenses looks fine, perhaps time to close this (and reopen in case someone else finds a misplaced license file)? ttf-bitstream-vera is still wrong, but fixed in CVS so whenever that package is rebuilt it should be fixed.
Comment by Jens Adam (byte) - Tuesday, 22 January 2008, 01:37 GMT
The only ones still left in [extra] are:
- flashplayer-standalone
- blas
- ttf-bitstream-vera (fixed in CVS, as already noted)

phrakture: why do I still have /var/abs/testing/core/support/openssh?
Comment by Fredrik (vEX) - Tuesday, 22 January 2008, 08:33 GMT
Well, flashplayer-standalone is also fixed in CVS, and flagged out-of-date so it should hopefully get fixed soon. And blas is also fixed in CVS, though I don't know when it's getting updated. Probably when/if they do a extra rebuild like they did for core.
Comment by Aaron Griffin (phrakture) - Thursday, 24 January 2008, 20:09 GMT
@byte: Ah, only the PKGBUILD was untagged as TESTING. Fixed

So this leaves only blas, correct?
Comment by Jens Adam (byte) - Friday, 25 January 2008, 17:41 GMT
The notice from core/support/ipw3945d/ipw3945d.install is the only one left, it seems.
Everything else is either fixed in HEAD or from community. By the way, latest ttf-bitstream-vera is only tagged CURRENT-64.

Another (very bikesheddy) thing I noticed:
Now that the dirname is clear, there's no consensus on the filename; some prefer license.txt, another one uses LICENSE, and others just copy the original file, if any.
But it's so irrelevant that I wouldn't post a bug for that, even if it's #9999. ;]

phrakture: openshh/PKGBUILD Rev. 1.66 is still tagged TESTING/TESTING-64 :p
Comment by Dan McGee (toofishes) - Wednesday, 14 May 2008, 03:03 GMT
What is left here? Are we close to closing this?
Comment by Jens Adam (byte) - Wednesday, 14 May 2008, 19:25 GMT
flashplayer-standalone and ttf-bitstream-vera are left (seems like old CVS HEAD didn't go into SVN), for the ones in community I left comments in AUR.
Comment by Jens Adam (byte) - Wednesday, 14 May 2008, 19:28 GMT
Btw, I noticed there are some differences between 32-bit and 64-bit ABS checkouts -- just to be clear, I only grep for 32-bit stuff.
Comment by Greg (dolby) - Sunday, 22 June 2008, 15:57 GMT
Seems only flashplayer-standalone is left. Assigning to brain0 for that reason