FS#56189 - {mkinitcpio} Add btrfs binary with fsck hook

Attached to Project: Arch Linux
Opened by Karol Babioch (johnpatcher) - Tuesday, 31 October 2017, 19:44 GMT
Last edited by Doug Newgard (Scimmia) - Wednesday, 01 November 2017, 05:45 GMT
Task Type Feature Request
Category Arch Projects
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Not sure whether this was already discussed sometime ago, if so feel free to close this down without further discussion. I would like to propose to add the btrfs binary /usr/bin/btrfs with the fsck hook, since fsck.btrfs is not actually useful and only a stub telling you that you need the real binary. In emergency cases it is too late and you don't have this binary in your initramfs. It can be added manually, but I think one might expect to have needed filesystem utilities included in the initramfs with the fsck hook.
This task depends upon

Closed by  Doug Newgard (Scimmia)
Wednesday, 01 November 2017, 05:45 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#29182 
Comment by Eli Schwartz (eschwartz) - Tuesday, 31 October 2017, 22:28 GMT
  • Field changed: Summary (Add btrfs binary with fsck hook → {mkinitcpio} Add btrfs binary with fsck hook)
  • Field changed: Category (Packages: Core → Arch Projects)
Have useful bug report summaries/descriptions gone out of style? Why are you leaving it to us to extrapolate that you are talking about the mkinitcpio project and move it into the right category?

Anyway I don't see why this is needed, the whole point of that shell script is to tell you that btrfs is a filesystem which does not need to be checked on every boot, and if you have some very specific reason to think it *does* need to be checked, then you should run it manually using x command.
Comment by Karol Babioch (johnpatcher) - Tuesday, 31 October 2017, 22:34 GMT
I'm sorry that I've missed out on the fact that I was talking about mkinitcpio. Had it in mind, forgot to mention it.

I stumbled upon this a couple of weeks back, when the system refused to boot (different reason) and I realized that I have fsck.btrfs available, but it is basically useless. I've added the original btrfs binary since then, but I do think that people might expect this tool available in these kinds of situations.

Other filesystems don't have a dedicated tool to manage them, so when running ext4, fsck.ext4 is good enough and will be included. I just think that everything should be in place to be able to check the filesystem in these emergencies. Not sure, if this is a valid point, though, it's up to you to decide :-).
Comment by Eli Schwartz (eschwartz) - Tuesday, 31 October 2017, 22:48 GMT
Hmm, I see where you are coming from I guess. Essentially, if something does go wrong then the user should be able to manually run it from the emergency shell?

Anyway implementing it should just be special-casing add_fsck() to apply special logic to btrfs as well. Actually, I think a case statement would be a lot more elegant anyway...
Comment by Doug Newgard (Scimmia) - Wednesday, 01 November 2017, 05:43 GMT
There is nothing to fsck, so adding some random binary will do nothing. If you want the binary, add the binary.

Loading...