FS#55989 - [tor] Use upstream provideed systemd unit rather than maintain our own

Attached to Project: Community Packages
Opened by BrLi (brli) - Saturday, 14 October 2017, 17:54 GMT
Last edited by freswa (frederik) - Tuesday, 06 October 2020, 16:50 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:

tor provides its own systemd units in src/tor-0.3.1.7/contrib/dist/tor.service.in
please consider use it instead of using the one in tree

Additional info:
* package version(s) 0.3.1.7
* config and/or log files etc.

```
build() {
(...)
./configure (...) --enable-systemd
(...)
package(){
(...)
# Install systemd service file
install -Dm0644 "contrib/dist/tor.service" "${pkgdir}/usr/lib/systemd/system/tor.service"
}
(...)
```

Steps to reproduce:

the diff is attached
   tor.service.diff (1.3 KiB)
This task depends upon

Closed by  freswa (frederik)
Tuesday, 06 October 2020, 16:50 GMT
Reason for closing:  Fixed
Additional comments about closing:  tor-0.4.4.5-2 in [community-testing]
Comment by Patrick LoPresti (patl) - Monday, 12 March 2018, 01:44 GMT
Yes, please.

At the very least, remove "User tor" from the tor.service file and put it in torrc instead... Allowing tor to start as root will let it bind to ports < 1024 before it drops privileges.
Comment by Eli Schwartz (eschwartz) - Monday, 12 March 2018, 02:14 GMT
Well, it looks like the upstream service file is basically the same as ours except it does more things, better...

Also we've gotten a number of bugreports to fix the one we do provide, which were fixed piecemeal but all seem to have been fixed in the upstream file as well...
Comment by Eli Schwartz (eschwartz) - Monday, 12 March 2018, 02:27 GMT
Also why do we ship a terribly outdated torrc and the upstream torrc.sample instead of a trivial modification to the upstream one? Seems like it would be less confusing to users; alternatively torrc seems to support include directories.

Loading...