FS#54829 - [python2-secretstorage] Should depend on pycryptodome

Attached to Project: Community Packages
Opened by Luke (Gaming4JC) - Saturday, 15 July 2017, 19:59 GMT
Last edited by Felix Yan (felixonmars) - Wednesday, 23 August 2017, 09:04 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Per upstream bug report: https://github.com/mitya57/secretstorage/issues/6

Pycrypto is deprecated and not updated since 2014.

Additional info:
* package version(s): python2-secretstorage 2.3.1-2

python2-pycryptodome is already in [community]
This task depends upon

Closed by  Felix Yan (felixonmars)
Wednesday, 23 August 2017, 09:04 GMT
Reason for closing:  Fixed
Additional comments about closing:  python-secretstorage 2.3.1-3
Comment by Eli Schwartz (eschwartz) - Sunday, 16 July 2017, 03:05 GMT
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Severity (Medium → Low)
  • Task assigned to Felix Yan (felixonmars)
Umm, that bugreport was resolved by migrating from the crypto module to cryptography, which is already a dependency of the package. Also, pycryptodome is not in fact in the repos, though pycryptodomex is (do read up on the difference) and would require modifying all imports downstream, which would be quite silly.
Assuming that we actually wanted to replace the (nonexistent) use of pycrypto with pycryptodome, it would anyways make more sense to file this against pycrypto rather than pick on one of its consumers...

Although it looks like the dependency on python2-crypto could be dropped altogether since it is no longer used, so I'll still assign this.

Loading...