FS#51628 - [apm] needs to be rebuilt for nodejs 7

Attached to Project: Community Packages
Opened by Nicola Squartini (tensor5) - Tuesday, 01 November 2016, 12:35 GMT
Last edited by Nicola Squartini (tensor5) - Wednesday, 02 November 2016, 15:37 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Felix Yan (felixonmars)
Nicola Squartini (tensor5)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Node.js 7 bumps NODE_MODULE_VERSION from 48 to 51. This breaks apm.


Additional info:

https://github.com/tensor5/arch-atom/issues/42
This task depends upon

Closed by  Nicola Squartini (tensor5)
Wednesday, 02 November 2016, 15:37 GMT
Reason for closing:  Fixed
Additional comments about closing:  apm 1.14.0-2
Comment by Balló György (City-busz) - Tuesday, 01 November 2016, 21:32 GMT
Felix, next time please upload major nodejs versions to staging repository first.

nodejs is in the stable repository now, so the apm package should be rebuilt ASAP.
Comment by Balló György (City-busz) - Tuesday, 01 November 2016, 21:47 GMT
Note that all binary nodejs modules need to be rebuilt on major nodejs update, but currently only the apm package contains binary modules (the *.node files), so it's enough to rebuild it only.
Comment by Doug Newgard (Scimmia) - Tuesday, 01 November 2016, 23:32 GMT
The TU that's the maintainer of apm was the one that opened this, making it pretty much useless. He could very well just have rebuilt it and been done. Reopening it and changing it completely doesn't help.
Comment by Balló György (City-busz) - Wednesday, 02 November 2016, 00:15 GMT
I think it's a valid task until apm is not rebuilt, since nodejs 7 is in stable repository, and apm is broken now. And Felix should know this issue when update major nodejs version next time.
Comment by Felix Yan (felixonmars) - Wednesday, 02 November 2016, 01:36 GMT
Actually nodejs 7.0.0-1 was in [community-testing] for 4~5 days, and I got no bug reports. I'll keep that in mind next time.
Comment by Doug Newgard (Scimmia) - Wednesday, 02 November 2016, 04:01 GMT
The purpose of this ticket wasn't to notify the maintainer of a problem, it was to bitch at Felix. That doesn't belong here.
Comment by roman (blackout) - Wednesday, 02 November 2016, 13:36 GMT
Also gulp is broken with nodejs v7

[code]
vmodule.js:474
throw err;
^

Error: Cannot find module 'internal/fs'
at Function.Module._resolveFilename (module.js:472:15)
at Function.Module._load (module.js:420:25)
at Module.require (module.js:500:17)
at require (internal/module.js:20:19)
at evalmachine.<anonymous>:17:20
at Object.<anonymous> (/srv/http/meter_management_web/node_modules/vinyl-fs/node_modules/graceful-fs/fs.js:11:1)
at Module._compile (module.js:573:32)
at Object.Module._extensions..js (module.js:582:10)
at Module.load (module.js:490:32)
at tryModuleLoad (module.js:449:12)

[/code]
Comment by Felix Yan (felixonmars) - Wednesday, 02 November 2016, 15:01 GMT
@blackout That's because your personal project located at "/srv/http/meter_management_web" is using an old graceful-js that won't work with latest nodejs.

Loading...