FS#50219 - [thunderbird] Enable Lightning extension

Attached to Project: Arch Linux
Opened by Balló György (City-busz) - Sunday, 31 July 2016, 22:34 GMT
Last edited by Doug Newgard (Scimmia) - Monday, 10 April 2017, 00:01 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 18
Private No

Details

I tested thunderbird 45.2.0 with --enable-calendar option (both with existing and new profile), and now I don't see any problems reported in  FS#49331  . Please Enable this option again.
This task depends upon

Closed by  Doug Newgard (Scimmia)
Monday, 10 April 2017, 00:01 GMT
Reason for closing:  Implemented
Additional comments about closing:  thunderbird 52.0-2
Comment by Doug Newgard (Scimmia) - Monday, 01 August 2016, 13:16 GMT
It was enabled after the linked bug report, but then disabled again in https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/thunderbird&id=c7100a3bdf66f2c53cc28e29ba7e9ee8865cefac

Commit message doesn't say why. heftig?
Comment by Jan Alexander Steffens (heftig) - Monday, 01 August 2016, 13:17 GMT
Disabled because the localizations do not cover lightning.
Comment by Balló György (City-busz) - Monday, 01 August 2016, 13:41 GMT
Fedora uses a custom script to fetch localizations for Lightning:
http://pkgs.fedoraproject.org/cgit/rpms/thunderbird.git/tree/mklangsource.sh

Maybe we could use it in a bit modified form?
Comment by Balló György (City-busz) - Monday, 01 August 2016, 16:43 GMT
I'm working on a solution to integrate translations, and I'll post it soon.
Comment by Balló György (City-busz) - Wednesday, 03 August 2016, 14:13 GMT
I attached a diff file for the current thunderbird package, which integrates translations. The same process can be applied for Firefox and SeaMonkey too. Steps:

1. Download translations for all supported languages as tagged snapshots from the mercurial repo. The list of supported languages can be found in mail/locales/shipped-locales.

2. Include translations in the Lightning extension. All of them are merged into one extension.

3. Create langpacks for Thunderbird.

4. Install langpacks.

For the 2. and 3. steps we need to merge translations with en-US to add the missing strings/files, and it requires a command-line tool called 'compare-locales'. I attached a PKGBUILD for this tool.

So we have multiple options:

1. Drop thunderbird-i18n package, and add all langpacks into the main thunderbird package.

2. Drop thunderbird-i18n, and use this package to create split packages for each langpacks as we currently provide them.

3. Don't touch langpacks at all, just include Lightning's translations in its extension, and leave the thunderbird-i18n package as is.
Comment by Jan Alexander Steffens (heftig) - Wednesday, 03 August 2016, 14:15 GMT
I'm sorry, all downloaded files must be part of the source array. Downloading during the build is to be avoided.
Comment by Jan de Groot (JGC) - Wednesday, 03 August 2016, 14:36 GMT
Shouldn't be so hard to move the list of languages to the sources array. Problem is maintaining that array...
Comment by Balló György (City-busz) - Wednesday, 03 August 2016, 14:51 GMT
I'll post a split package with proper source array soon.
Comment by Balló György (City-busz) - Wednesday, 03 August 2016, 18:43 GMT
Here is a better diff file for the current thunderbird package. Lightning and langpacks are in split packages.
Comment by André Fettouhi (A.Fettouhi) - Saturday, 08 April 2017, 05:07 GMT
Since Thunderbird 52 is out now and there is no working Lightning extension ATM, could this be reconsidered?
Comment by Moabit (Moabit) - Sunday, 09 April 2017, 12:38 GMT
+1. The separate add-on is no longer compatible, but adding `ac_add_options --enable-calendar` to the PKGBUILD works. I'm not totally sure, but my understanding is that from now on, Lightning will only be available bundled with Thunderbird. Some discussion at this Arch thread [1], and a pertinent reply from the Lightning devs here [2].

[1] https://bbs.archlinux.org/viewtopic.php?pid=1703104
[2] https://addons.mozilla.org/en-US/thunderbird/addon/lightning/reviews/857710/
Comment by patrick (potomac) - Sunday, 09 April 2017, 17:16 GMT
@Moabit : can you post as attached file the full modified PKGBUILD which allowed the lightning plugin to be built ?
Comment by patrick (potomac) - Sunday, 09 April 2017, 21:51 GMT
thunderbird package has just been updated ( 52.0-2 ), it solves the problem
Comment by Moabit (Moabit) - Sunday, 09 April 2017, 22:16 GMT
@potomac Yes, so my PKGBUILD [1] was fairly similar to 52.0-2. I can also confirm that this version fixes the problem.

[1] https://bbs.archlinux.org/viewtopic.php?pid=1702765#p1702765

Loading...