FS#48893 - [mate-themes] Upgrade from 1.12.2-1 to 3.20.5-1 breaks all themes

Attached to Project: Community Packages
Opened by Troy Engel (TE) - Monday, 11 April 2016, 14:47 GMT
Last edited by Doug Newgard (Scimmia) - Tuesday, 12 April 2016, 02:13 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The massive package upgrade this morning to support GTK3 3.20 has caused the themes to break -- in Firefox, highlight colors don't work in any control (the URL bar, the text boxes, combo boxes - everywhere). Other non GTK3 apps (generally most of MATE gtk2) are fine, it's just those GTK3 apps like Firefox.

If I switch to a few themes - Clearlooks for example - that are part of gtk-engines it's fine, I get my highlighting back. I have tested all the themes in mate-themes, only "ContrastHighInverse" seems to work but these are all broken:

BlackMATE
Blue-Submarine
BlueMenta
Green-Submarine
Menta
Shiny
TraditionalGreen
TraditionalOk

Additional info:
* package version(s)

$ ls /var/cache/pacman/pkg/mate-themes-*
/var/cache/pacman/pkg/mate-themes-1.12.2-1-any.pkg.tar.xz
/var/cache/pacman/pkg/mate-themes-3.20.5-1-any.pkg.tar.xz

Steps to reproduce:

Due to the large number of packages released as part of this update, trying to roll back just one package to determine if it's, say, Firefox is hard -- icu was updated, which has a dep list of a dozen other apps so it would take rolling back some 20-ish packages.
This task depends upon

Closed by  Doug Newgard (Scimmia)
Tuesday, 12 April 2016, 02:13 GMT
Reason for closing:  Duplicate
Additional comments about closing:   FS#48783 
Comment by Troy Engel (TE) - Monday, 11 April 2016, 15:07 GMT
It appears the ones that are broken contain the gtk-3.0 subdir/ elements, those that work are the ones missing that (using my Clearlooks example) so maybe it's that it's falling back to the default (Adwaita) when missing. I performed a test like so:

$ cd ~/.themes
$ cp -a /usr/share/themes/TraditionalOk .
$ mv TraditionalOk Fog
$ mv Fog/gtk-3.0 Fog/gtk-3.0.old

If I now select Fog (random name I chose), the controls work and it appears like the Adwaita fallback. I have tons of errors in my .xsession-errors log like so:

(nm-applet:820): Gtk-WARNING **: Theme parsing error: gtk-widgets-img.css:20:28: The :insensitive pseudo-class is deprecated. Use :disabled instead.
(nm-applet:820): Gtk-WARNING **: Theme parsing error: gtk-widgets-img.css:106:18: The :insensitive pseudo-class is deprecated. Use :disabled instead.
(nm-applet:820): Gtk-WARNING **: Theme parsing error: gtk-widgets-img.css:107:31: The :insensitive pseudo-class is deprecated. Use :disabled instead.
(nm-applet:820): Gtk-WARNING **: Theme parsing error: gtk-widgets-img.css:108:37: The :insensitive pseudo-class is deprecated. Use :disabled instead.

There are tons of these of all sorts throwing theme parsing errors in lots of the CSS files, here's a few more from Firefox:

(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:62:39: The :prelight pseudo-class is deprecated. Use :hover instead.
(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:350:25: The :prelight pseudo-class is deprecated. Use :hover instead.
(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:351:25: The :prelight pseudo-class is deprecated. Use :hover instead.
(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:456:66: The :insensitive pseudo-class is deprecated. Use :disabled instead.
(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:480:95: The :prelight pseudo-class is deprecated. Use :hover instead.
(firefox:2905): Gtk-WARNING **: Theme parsing error: mate-applications.css:522:36: The :insensitive pseudo-class is deprecated. Use :disabled instead.

So somehow these gtk-3.0 CSS files need to be converted (?) to using whatever is wanted by the new GTK3 update, this isn't my forte to know what though.
Comment by Balló György (City-busz) - Monday, 11 April 2016, 15:37 GMT
GTK+ 3.20 changed a lot, and not all themes are fully compatible yet.

You should report all theme related problems to the upstream developers:
https://github.com/mate-desktop/mate-themes/issues

At the meanwhile, I recommend to use the default Adwaita theme.
Comment by Troy Engel (TE) - Monday, 11 April 2016, 15:48 GMT
Roger that, I reported it upstream and linked here.

https://github.com/mate-desktop/mate-themes/issues/114

I confirm that letting it fall back to Adwaita for 3.0 is fine (using my above hack) - it's a bit ugly to have two competing themes at play but it works for now. :) I had to also comment out .config/gtk-3.0/settings.ini "gtk-theme-name=TraditionalOk" for full resolution.

Loading...