FS#48354 - [lm_sensors] missing doc files

Attached to Project: Arch Linux
Opened by Ziusudra (Ziusudra) - Saturday, 27 February 2016, 04:51 GMT
Last edited by Antonio Rojas (arojas) - Saturday, 26 May 2018, 12:25 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Eric Belanger (Snowman)
Antonio Rojas (arojas)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
The contents of the doc directory in the source package should be copied to /usr/share/doc/lm-sensors

the site is still gone - mirror at: http://pkgs.fedoraproject.org/repo/pkgs/lm_sensors/lm_sensors-3.4.0.tar.bz2/c03675ae9d43d60322110c679416901a/lm_sensors-3.4.0.tar.bz2

That directory it is in is its md5 hash.
This task depends upon

Closed by  Antonio Rojas (arojas)
Saturday, 26 May 2018, 12:25 GMT
Reason for closing:  Won't implement
Comment by Leonid Isaev (lisaev) - Sunday, 20 May 2018, 03:31 GMT
Would the attach diff fix this? (pls notice that it also includes fix for  FS#58669 ).
   PKGBUILD.diff (1.8 KiB)
Comment by Ziusudra (Ziusudra) - Sunday, 20 May 2018, 04:13 GMT
Yes. (That said, I don't currently have an Arch install available to test.)
Comment by Antonio Rojas (arojas) - Friday, 25 May 2018, 06:54 GMT
I don't see any reason to install them - most of the contents of the doc dir is related to installing/packaging. Some other files are obsolete (the content of vid is not needed since linux 2.6.9) or outdated (temperature-sensors refers to an unexistant doc/chips dir). It seems to me that installing inaccurate or obsolete docs would cause more harm than good.
Comment by Leonid Isaev (lisaev) - Saturday, 26 May 2018, 00:10 GMT
You are right for v3.4 (which is itself outdated), but I looked at the documentation at [1], i.e. the current git repos, and noticed that some docs were updated 4 months ago... So I quickly changed the PKGBUILD, while at it. Also, I followed Fedora and installed README which is updated as well... But I agree, this is not urgent...

Also, I'm sorry for hijacking this bugreport, but we can also drop the fancontrol patch that addressed  FS#34187 . It didn't fix anything (simply refactored the code and hid the error). The actual bug was fixed upstream [2] in 2014 before 3.4 was released, so this version already includes the fix...

[1] https://github.com/groeck/lm-sensors
[2] https://github.com/groeck/lm-sensors/commit/af447db31acad7ad8e43afa717e0646daf66721b#diff-bdf224e12ec9b41f18d882867ca18165
Comment by Antonio Rojas (arojas) - Saturday, 26 May 2018, 12:25 GMT
Thanks, removed the patch. As for the docs, it doesn't make much sense for the current release as noted. If/when a new version is released we can reevaluate

Loading...