FS#46645 - scripts/notify.py: last commit broke message headers/threading

Attached to Project: AUR web interface
Opened by Jens Adam (byte) - Saturday, 10 October 2015, 13:31 GMT
Last edited by Lukas Fleischer (lfleischer) - Monday, 15 February 2016, 18:42 GMT
Task Type Bug Report
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Medium
Priority Normal
Reported Version 4.1.0
Due in Version 4.2.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Commit: https://projects.archlinux.org/aurweb.git/commit/scripts/notify.py?id=6681e565512825193feafb8b9e6114e0bea595b9

Last message with custom/correct Message-ID and no References/In-Reply-To: [PRQ#4118] (see your mail archive)

Since then even the mails from the original request get References and In-Reply-To headers and all mails have normal Postfix-generated Message-IDs.

(btw: "Reported Version" in FlySpray should be 4.1.1)
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Monday, 15 February 2016, 18:42 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in 4.2.0.
Comment by Lukas Fleischer (lfleischer) - Saturday, 10 October 2015, 14:46 GMT
Actually, this doesn't seem to be related to commit 6681e56 (notify: Do not wrap references, 2015-10-03)... The Python notification script probably never did the right thing here. Something that we should fix soon.
Comment by Jens Adam (byte) - Saturday, 10 October 2015, 15:07 GMT
Well, the commit is seven days old and that's exactly when the first 'broken' mails arrived.
Comment by Lukas Fleischer (lfleischer) - Saturday, 10 October 2015, 15:11 GMT
That is also when aurweb 4.1.0 (including a complete rewrite of the notification routines) was released, though. Commit 6681e56 (notify: Do not wrap references, 2015-10-03) actually isn't part of any release yet and was applied on our live setup only yesterday...

Loading...