FS#44467 - [makepkg] pkgrel variable is ignored when the PKGBUILD includes a pkgver() function.

Attached to Project: Pacman
Opened by Dustin Falgout (lots0logs) - Saturday, 04 April 2015, 23:11 GMT
Last edited by Andrew Gregory (andrewgregory) - Sunday, 05 April 2015, 05:58 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version 4.2.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:

makepkg ignores pkgrel variable when a pkgver function is included in the PKGBUILD (pkgrel is always 1). Usually this is the desirable behavior because VCS versions are expected to change between builds. Though occasionally you might need to make a change to the PKGBUILD even though the VCS version has not changed since the last build.

Steps to Reproduce:

1. Set the pkgrel variable to something other than 1 in a PKGBUILD that includes a pkgver function.
2. Build the package.
3. The version of the package will have a pkgrel of 1 regardless of what you set in the PKGBUILD.
This task depends upon

Closed by  Andrew Gregory (andrewgregory)
Sunday, 05 April 2015, 05:58 GMT
Reason for closing:  Not a bug
Comment by Andrew Gregory (andrewgregory) - Sunday, 05 April 2015, 01:21 GMT
makepkg does not ignore pkgrel; it resets pkgrel to 1 if pkgver is actually updated. If you are seeing different behavior, please provide an example PKGBUILD.
Comment by Dustin Falgout (lots0logs) - Sunday, 05 April 2015, 01:45 GMT
You're right, my mistake. I did not update the first declaration of pkgver in the PKGBUILD (honestly, I never do). Its clear to me now why it was changing it to 1. Though, I find this behavior to be inconsistent. For pkgver the user is expected to update it before rebuilding the package, while the pkgrel is automatically handled with no option to override it. They should both be automatically handled or they should both require the packager to update the values. IMO (of course). Anyway, thanks for taking a look at this. Cheers!

Loading...