FS#43898 - [mpv] jack audio device missing

Attached to Project: Community Packages
Opened by Allen Li (darkfeline) - Friday, 20 February 2015, 22:18 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Wednesday, 04 March 2015, 19:07 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Christian Hesse (eworm)
Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Arch Linux mpv build no longer supports jack.

Fix: add --enable-jack flag
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Wednesday, 04 March 2015, 19:07 GMT
Reason for closing:  Fixed
Comment by Philip Sequeira (qmega) - Saturday, 21 February 2015, 00:52 GMT
It doesn't need a flag, it just needs to be present when building. Probably a depend on jack needs to be added; it was covered by portaudio before that was removed.
Comment by Bartłomiej Piotrowski (Barthalion) - Thursday, 26 February 2015, 17:37 GMT
The --enable-jack flag is pointless, WAF automatically detects its availability basing on presence of headers.
Comment by Christian Hesse (eworm) - Thursday, 26 February 2015, 18:58 GMT
Sure it does. But take the other way round: If we have --enable-jack in PKGBUILD and upstream removes support for jack we will notice and can receive the dependency. Chances are we would not notice without the extra argument.

mpv 0.8.0-1 had a dependency to portaudio, but upstream had removed support (see  FS#43853 ).

Are there and guide lines for this?
Comment by Bartłomiej Piotrowski (Barthalion) - Thursday, 26 February 2015, 19:11 GMT
Namcap throws an warning about unused dependency (or -ies). It's just my fault that I haven't paid attention to it.

Loading...