FS#42841 - [vim-runtime] 7.4.516 runtime package fails to build

Attached to Project: Arch Linux
Opened by jason ryan (jasonwryan) - Wednesday, 19 November 2014, 07:47 GMT
Last edited by Anatol Pomozov (anatolik) - Wednesday, 19 November 2014, 23:09 GMT
Task Type Bug Report
Category Packages: Testing
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: Vim 7.4.516 in [testing] fails to build the runtime package when using ABS or Asp as the relevant directory is rm'ed in all but the gvim package build function.

Additional info:
* 7.4.516-

Steps to reproduce: attempt to build any of the vim packages, such as vim-minimal, and the runtime package will fail, complaining about missing files. In the package function for each of these packages, *other than gvim*, there is the following lines:
# Runtime provided by runtime package
rm -r "${pkgdir}"/usr/share/vim

and in vim_runtime:
# Install the runtime split from gvim
install -dm755 "${pkgdir}"/usr/share
mv "${srcdir}"/runtime-install "${pkgdir}"/usr/share/vim

which of course does not exist.

Fixed by replacing the lines in the other packages with:

# Move the runtime for later packaging
mv "${pkgdir}"/usr/share/vim "${srcdir}"/runtime-install
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Wednesday, 19 November 2014, 23:09 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in the tree
Comment by Anatol Pomozov (anatolik) - Wednesday, 19 November 2014, 14:50 GMT
I can build it with and without clean chroot without issues.

Could you please provide exact instructions how to reproduce it.
Comment by Doug Newgard (Scimmia) - Wednesday, 19 November 2014, 15:53 GMT
He's talking about building individual packages, using makepkg's --pkg option.
Comment by Anatol Pomozov (anatolik) - Wednesday, 19 November 2014, 16:13 GMT
I do not think using --pkg makes much sense. The heaviest function build() needs all subpackages (vim gvim vim-minimal ..)
Comment by Doug Newgard (Scimmia) - Wednesday, 19 November 2014, 16:20 GMT
Conversely, building a gvim package doesn't make much sense when you only want vim-minimal and vim-runtime. Takes more time for no gain. That's why --pkg gets used. Package functions should be independent of each other.
Comment by Anatol Pomozov (anatolik) - Wednesday, 19 November 2014, 16:36 GMT
package() functions are split, build() function is a large monolithic function. And it is what takes the most of the time.
Comment by Doug Newgard (Scimmia) - Wednesday, 19 November 2014, 16:37 GMT
Which, honestly, is a bit of abuse of a split PKGBUILD. It was made for splitting up a single build into multiple packages, not doing multiple builds.

That doesn't really matter, though, makepkg provides the option, it should be supported. Ideally, the package functions shouldn't change anything in $srcdir at all.
Comment by jason ryan (jasonwryan) - Wednesday, 19 November 2014, 17:04 GMT
Yes, I am not interested in building gvim to build vim-minimal...
Comment by Anatol Pomozov (anatolik) - Wednesday, 19 November 2014, 18:37 GMT
I just committed changes that break install_vim-runtime dependency to gvim. Please get the latest version and check if it fixes your issue.
Comment by jason ryan (jasonwryan) - Wednesday, 19 November 2014, 22:00 GMT
Thanks Anatol: that fixes it.

Loading...