FS#41479 - CVS sources are extracted before pkgver gets bumped

Attached to Project: Pacman
Opened by Aldrik (N30N) - Tuesday, 05 August 2014, 21:34 GMT
Last edited by Allan McRae (Allan) - Saturday, 09 August 2014, 06:26 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version 4.1.2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Summary and Info:
As the title says, the extraction happens before the pkgver gets bumped. So if you use a fragment that relies on this (such as "tag=v${pkgver}") the extracted/checked-out sources will be from the previous pkgver.


Example PKGBUILD to Reproduce: https://gist.github.com/aldrik/7081f3c8fe5f63067148/446e4fe8d5c646a1b28fa27bdbeaa03923d633dc

The above will build v2.0.1 on first run claiming it's the latest version and if you run it again it'll build then build the correct version.

A workaround is to add the repository to the "noextract" array and preform the extraction in the "prepare" function, like so: https://gist.github.com/aldrik/7081f3c8fe5f63067148/955c99df37a384b63dad194939aaac210378da93
This task depends upon

Closed by  Allan McRae (Allan)
Saturday, 09 August 2014, 06:26 GMT
Reason for closing:  Not a bug
Comment by Dave Reisner (falconindy) - Tuesday, 05 August 2014, 22:33 GMT
Hrm, I think this working as intended, and that you're misusing the pkgver() function. The stdout of this function is meant to tell makepkg what version it's *currently* building, not what version it *should* build.

Loading...