FS#40867 - [libnfs] patch needed to allow xbmc to see nfs shares

Attached to Project: Community Packages
Opened by John (graysky) - Monday, 16 June 2014, 22:16 GMT
Last edited by Ike Devolder (BlackEagle) - Tuesday, 17 June 2014, 18:49 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Ike Devolder (BlackEagle)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Evan bisected a bug which prevents xbmc from using nfs links through the GUI. Read about it in this thread[1] and in this[2] upstream issue report. Application of the attached patch restores functionality to xbmc. Since it has been a few weeks with no reply from upstream as far as I can tell, I feel that patching our package is the prudent move.

1. https://bbs.archlinux.org/viewtopic.php?id=182004
2. https://gist.github.com/EvanPurkhiser/48ddb38860753cac535b/raw/66985079baa5e3fdec98c17b3520f6aa72e27331/libnfs-1.9.3-1-x86_64.pkg.tar.xz


Additional info:
* package version(s) 1.9.3-1
   undo_d5f7880.patch (0.3 KiB)
This task depends upon

Closed by  Ike Devolder (BlackEagle)
Tuesday, 17 June 2014, 18:49 GMT
Reason for closing:  Fixed
Additional comments about closing:  libnfs 1.9.3-2
Comment by Evan Purkhiser (EvanPurkhiser) - Monday, 16 June 2014, 22:47 GMT
The same as https://bugs.archlinux.org/task/40868 I'm not sure why this patch is slightly different from the patch in my bug report.
Comment by Evan Purkhiser (EvanPurkhiser) - Monday, 16 June 2014, 22:57 GMT
Also, it looks like the upstream issue link is incorrect in this bug report, here's the proper link: https://github.com/sahlberg/libnfs/issues/78
Comment by John (graysky) - Tuesday, 17 June 2014, 07:49 GMT
Oops, my bad on the wrong #2 in my original, sorry about that. The patch is slightly different due to the line number mismatch I saw when I looked at the file from the source tarball that the PKGBUILD in abs pulled down. The line numbers are simply wrong for me.
Comment by Evan Purkhiser (EvanPurkhiser) - Tuesday, 17 June 2014, 07:51 GMT
The patch changes are also slightly different though too, check the addition, one changes the `>=` to a `=` the other to a `>`

https://bugs.archlinux.org/task/40867?getfile=11902
https://github.com/sahlberg/libnfs/commit/d5f7880641c979b986f6c4d7b6502bd7e768a9ea.patch
Comment by Evan Purkhiser (EvanPurkhiser) - Tuesday, 17 June 2014, 07:57 GMT
I don't think the line numbers should matter, I just tried applying the patch like so and it worked fine:

$ yaourt -G libnfs
$ cd libnfs/src/libnfs-libnfs-1.9.3/
$ patch -p1 < <(curl https://github.com/sahlberg/libnfs/commit/d5f7880641c979b986f6c4d7b6502bd7e768a9ea.patch)
Comment by John (graysky) - Tuesday, 17 June 2014, 08:00 GMT
You're right... I jacked that up. Mine should have the > rather than =

(Curses under breath).
   undo_d5f7880_try2.patch (0.3 KiB)
Comment by Evan Purkhiser (EvanPurkhiser) - Tuesday, 17 June 2014, 08:03 GMT
No problem :) I hate to nitpick more, but just for clarity, we're not undoing the d5f7880 commit but instead applying it, since it's the commit that actually fixes the issue.
Comment by John (graysky) - Tuesday, 17 June 2014, 08:06 GMT
No problem, I usually rename the patches that fix things to "unfuck_blah.patch" but thought I would attempt to be more professional :D
Comment by Evan Purkhiser (EvanPurkhiser) - Tuesday, 17 June 2014, 08:07 GMT
Here's my attempt at a super professional looking patch file that I usually see included with PKGBUILDs :)
   0001-nfs_normalize_path-don-t... (0.8 KiB)

Loading...