FS#37011 - [makepkg] license check on sourcex package creation is too strict

Attached to Project: Pacman
Opened by Dave Reisner (falconindy) - Saturday, 21 September 2013, 13:04 GMT
Last edited by Allan McRae (Allan) - Monday, 14 October 2013, 03:21 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Allan McRae (Allan)
Architecture All
Severity Low
Priority Normal
Reported Version 4.1.2
Due in Version 4.2.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Split PKGBUILDs which declare the license only in the package_* functions will erroneously cause makepkg to complain about a missing license field in source package creation. core/systemd reproduces the problem:

https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/systemd&id=b85e1192af61dda37eede5aec5d755d94a9273ec

We'd need to extend the check to make sure that all packages in a split PKGBUILD have a license in some form.

Snowballing...
This also makes me wonder if we shouldn't create functions to do the value extraction from the PKGBUILD, e.g. get_package_attribute() and get_package_list_attribute() to do the declare -f | eval | sed | grep | eval | ... dance. We seem to do a lot of this and repeat ourselves.
This task depends upon

Closed by  Allan McRae (Allan)
Monday, 14 October 2013, 03:21 GMT
Reason for closing:  Implemented
Additional comments about closing:  adfab9c8
Comment by Allan McRae (Allan) - Saturday, 21 September 2013, 14:09 GMT
Anyone want to convince me to actually keep the license check? I'm happy for it to go...
Comment by Dave Reisner (falconindy) - Sunday, 22 September 2013, 00:47 GMT
One might argue that license is a distribution concern and not one of packages in general. In this case, a tool like namcap is sufficient for checking the license (and I think already does?).

Sure, let's just drop it. The check itself is in a strange place.

Loading...