FS#36186 - [fltk] Add tigervnc patches

Attached to Project: Arch Linux
Opened by U (Gusar) - Wednesday, 17 July 2013, 17:48 GMT
Last edited by Bartłomiej Piotrowski (Barthalion) - Saturday, 14 September 2013, 08:20 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Ronald van Haren (pressh)
Evangelos Foutras (foutrelis)
Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

Tigervnc 1.2 used an internal fltk copy patched to support it's fltk-based vncviewer. Tigervnc 1.3 doesn't have such an internal copy anymore. So if Arch wants to provide a fully functional Tigervnc, the fltk package will need to be patched. The patches can be applied to the 1.3.2 release. Here's a list of them, along with links to the fltk bugtracker where they can be obtained:

http://www.fltk.org/str.php?L2599
fltk-1_v4.3.x-keyboard-x11.patch

http://www.fltk.org/str.php?L2636
fltk-1.3.x-clipboard.patch
fltk-1_v5.3.x-clipboard-x11.patch

http://www.fltk.org/str.php?L2659
pixmap_v2.patch

http://www.fltk.org/str.php?L2660
fltk-1_v5.3.x-cursor.patch

http://www.fltk.org/str.php?L2802
fltk-1_v2.3.0-modal.patch

http://www.fltk.org/str.php?L2816
fltk-1_v3.3.0-icons.patch

http://www.fltk.org/str.php?L2860
fltk-1.3.x-screen_num.patch
fltk-1_v3.3.x-multihead.patch

I think it'd be cleaner to combine all those patches into one, as attached. Not applying these patches leads to things described in this thread: https://bbs.archlinux.org/viewtopic.php?id=166735
   tigervnc.patch (114.4 KiB)
   PKGBUILD (2 KiB)
This task depends upon

Closed by  Bartłomiej Piotrowski (Barthalion)
Saturday, 14 September 2013, 08:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  fltk 1.3.2-3
Comment by John (graysky) - Saturday, 20 July 2013, 02:03 GMT
@Gusar - I rebuilt fltk using your PKGBUILD then rebuild tigervnc. Upon restarting my vncserver, I still do not have the ctrl key. Did you miss a patch perhaps? Note - i686.
Comment by U (Gusar) - Saturday, 20 July 2013, 10:43 GMT
Those are all the patches listed in the README. Well, there's a few more, but they're for OSX and Windows. Does ctrl work if you use fltk-snapshot from AUR? It's a SVN snapshot of fltk slightly older than the 1.3.2 release and contains older versions of these patches.
Comment by U (Gusar) - Saturday, 20 July 2013, 11:21 GMT
One other thing: With these patches, libxcursor becomes a dependency of fltk, so here's an updated PKGBUILD for that.
   PKGBUILD (2.1 KiB)
Comment by John (graysky) - Saturday, 20 July 2013, 14:31 GMT
I built/installed fltk-snapshot and then build tigervnc against it. Upon restarting my vncserver, I still do not have the ctrl key :(
Comment by John (graysky) - Monday, 22 July 2013, 11:20 GMT
This is larger than just the tigervnc package; x11vnc is currently also exhibiting the same behavior of no ctrl keys working.
Comment by U (Gusar) - Monday, 22 July 2013, 12:55 GMT
That's just weird. I'm using fltk-snapshot and tigervnc-svn (should be exactly the same as the 1.3 release), and ctrl works here. Could it have something to do with the keyboard layout? I'm using the "si" layout.
Comment by John (graysky) - Monday, 05 August 2013, 20:55 GMT
No idea about the keyboard layout. Which in file is that stored?
Comment by U (Gusar) - Tuesday, 06 August 2013, 11:44 GMT
VNC doesn't control the layout, it uses whatever is configured on the machine where you're starting the viewer. If it's a Linux machine, use setxkbmap or your DE's graphical keyboard configurator. If it's a Windows machine, use it's layout switcher thingy near the system tray.

If you look at the forum thread I linked to, someone reports that the fltk-snapshot + tigervnc-svn combo works. Which is weird, because the 1.3 and svn codebases are pretty much identical, as you can see on the attached diff. Give it a try, see if the fltk-snapshot + tigervnc-svn combo works for you too.

And note, it seems it's a client-side issue, the server is irrelevant, it's all about the viewer.
   svn.diff (8.3 KiB)
Comment by John (graysky) - Tuesday, 13 August 2013, 22:21 GMT
<< Removed by author >>
Comment by John (graysky) - Saturday, 17 August 2013, 12:06 GMT
Some info perhaps relevant from flyspray #36424. Testing alternative clients is a good idea.
Using either x11vnc on the server or the current tigervnc as the server, and connecting with the following clients, I am _unable_ to invoke any of the following actions: ctrl+F or ctlr+N or ctrl+T in chromium or in thunar:
*vinagre
*tigervnc
*remmina

The following DO work:
*gtk-vncviewer
*realvnc-viewer (from the AUR)
Comment by John (graysky) - Saturday, 17 August 2013, 12:34 GMT
Server running on machine A: official repo packages of tigervnc and fltk.
Client running on machine B: fltk build from your proposed patch and PKGBUILD attached in this flyspray then built tigervnc from ABS.
Result: Ctrl key combos such as ctrl+f and ctrl+w etc work fine now.

Conclusion: pending independent confirmation of my results, apply the patch that Gusar proposes in this flyspray and then rebuild tigervnc against the freshly patched fltk.
Comment by John (graysky) - Saturday, 17 August 2013, 12:43 GMT
Also, the source path changed and the current PKGBUILD lacks a prepare function. I have fixed both of these in the included PKGBUILD which is to be used with the following files:
*Gusar's tigervnc.patch
*fltk.install
*fltk-games.install
   PKGBUILD (2.2 KiB)
Comment by Alexander F. Rødseth (xyproto) - Monday, 26 August 2013, 19:38 GMT
fltk is currently an orphan, assigning to maintainers of packages in extra that depend on fltk (octave)
Comment by John (graysky) - Sunday, 08 September 2013, 19:01 GMT
@Alex - That sucks (orphaned package in official repos). This really needs to get implemented...
Comment by Alexander F. Rødseth (xyproto) - Sunday, 08 September 2013, 21:20 GMT
No response from the current maintainer of octave (only package in extra that depends on fltk), assigning to the last packager of octave and fltk as well.

Loading...