Arch Linux

I wonder what are the thoughts on this. Is it too hard to implement? Are there concerns of comment history becoming more difficult to read?

The bug tracker and the forums also allow editing, so why not the AUR?

I am in favor of implementing this but there is a conflict with  FS#14840  (allowing to edit comments also means that users can "delete" their comments by replacing them with an empty text).

That should be allowed in my opinion, it's the internet after all (this one has more votes anyway, even though it's more recent).

The forums and the tracker only have the *edit* button, which takes care of the unkown number of missing comments and helps with readability as long as the "last edit" timestamp is provided.

I like this idea. Maybe give a 1 minute grace period where the comment can be edited and before the comment gets emailed to people who have notifications enabled.

People sending basically the same comment with minor changes is kind of annoying.

I'm thinking about how to implement this feature, and a 1 minute grace period (make it five, but that doesn't matter) is hard to implement: should we use a cron job to check whether there are messages to send (or to wait a little bit longer)? Should the server spawn a process that just waits until the grace period has finished and then checks if the comment has been changed (and if not: send the message)?

Though not ideal, it's easier to implement the way the forum sends notifications: send them immediately and don't (re)send anything after a post is edited.

Implementing a grace period will be easier with Lukas' reworking of the notifications into a python script, I think. Best would probably be to make all emails and such be background jobs, run under eg Celery, so that the AUR would only queue a job, and then a celery worker would actually run the task. (Note that I don't know if Celery in particular supports that kind of delayed tasks, it was just an example.)

I suppose a 5 minute period since the last edit is even harder (would also result in consecutive comments having to be held up until the oldest one gets sent).

Or make possible to see the old text, aybe an option to see all the edits in such message.

That's rather cumbersome to implement and hardly ever necessary (most edits (i.e., new posts and deletions of the old ones) are now corrections and/or additions).