FS#34690 - _Need_ the ability to edit comments

Attached to Project: AUR web interface
Opened by (Det) - Monday, 08 April 2013, 23:05 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 03 October 2015, 08:04 GMT
Task Type Feature Request
Category Backend
Status Closed
Assigned To Lukas Fleischer (lfleischer)
Architecture All
Severity Low
Priority Normal
Reported Version 2.0.1
Due in Version 4.1.0
Due Date Undecided
Percent Complete 100%
Votes 9
Private No

Details

Because it's just SO annoying having to remove/resend your post - especially if there's some more from other people in between.

Nobody likes being notified a zillion times about the same thing anyway.
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Saturday, 03 October 2015, 08:04 GMT
Reason for closing:  Implemented
Additional comments about closing:  Implemented in 4.1.0.
Comment by (Det) - Monday, 22 June 2015, 10:21 GMT
I wonder what are the thoughts on this. Is it too hard to implement? Are there concerns of comment history becoming more difficult to read?

The bug tracker and the forums also allow editing, so why not the AUR?
Comment by Lukas Fleischer (lfleischer) - Monday, 22 June 2015, 10:25 GMT
I am in favor of implementing this but there is a conflict with  FS#14840  (allowing to edit comments also means that users can "delete" their comments by replacing them with an empty text).
Comment by (Det) - Monday, 22 June 2015, 10:32 GMT
That should be allowed in my opinion, it's the internet after all (this one has more votes anyway, even though it's more recent).

The forums and the tracker only have the *edit* button, which takes care of the unkown number of missing comments and helps with readability as long as the "last edit" timestamp is provided.
Comment by Loui Chang (louipc) - Sunday, 28 June 2015, 13:54 GMT
I like this idea. Maybe give a 1 minute grace period where the comment can be edited and before the comment gets emailed to people who have notifications enabled.

People sending basically the same comment with minor changes is kind of annoying.
Comment by Marcel Korpel (Marcel-) - Sunday, 28 June 2015, 20:21 GMT
I'm thinking about how to implement this feature, and a 1 minute grace period (make it five, but that doesn't matter) is hard to implement: should we use a cron job to check whether there are messages to send (or to wait a little bit longer)? Should the server spawn a process that just waits until the grace period has finished and then checks if the comment has been changed (and if not: send the message)?

Though not ideal, it's easier to implement the way the forum sends notifications: send them immediately and don't (re)send anything after a post is edited.
Comment by Johannes Löthberg (demize) - Sunday, 28 June 2015, 20:59 GMT
Implementing a grace period will be easier with Lukas' reworking of the notifications into a python script, I think. Best would probably be to make all emails and such be background jobs, run under eg Celery, so that the AUR would only queue a job, and then a celery worker would actually run the task. (Note that I don't know if Celery in particular supports that kind of delayed tasks, it was just an example.)
Comment by (Det) - Sunday, 28 June 2015, 21:30 GMT
I suppose a 5 minute period since the last edit is even harder (would also result in consecutive comments having to be held up until the oldest one gets sent).
Comment by Pablo Lezaeta (Jristz) - Sunday, 13 September 2015, 21:23 GMT
Or make possible to see the old text, aybe an option to see all the edits in such message.
Comment by Marcel Korpel (Marcel-) - Sunday, 13 September 2015, 22:39 GMT
That's rather cumbersome to implement and hardly ever necessary (most edits (i.e., new posts and deletions of the old ones) are now corrections and/or additions).

Loading...