FS#3289 - makepkg should check FTPAGENT return code
Attached to Project:
Pacman
Opened by Daniel YC Lin (dlin) - Tuesday, 04 October 2005, 09:57 GMT
Last edited by Aaron Griffin (phrakture) - Friday, 08 December 2006, 22:57 GMT
Opened by Daniel YC Lin (dlin) - Tuesday, 04 October 2005, 09:57 GMT
Last edited by Aaron Griffin (phrakture) - Friday, 08 December 2006, 22:57 GMT
|
Details
In makepkg, the following code is too weak.
--- $FTPAGENT $netfile 2>&1 if [ ! -f $file ]; then error "Failed to download $file" msg "Aborting..." exit 1 fi --- On most time, wget get a partial file, and makepkg assume it is full package. I suggest there should deal with three thing. 1. Whenever FTPAGENT return code is not 0, think it is failed 2. When all files download, also touch a file 'src/download.done' that means all file have successful download. The makepkg can skip download when it found the file. 3. There should have a method to deal with partial download on /var/cache/pacman/src, I suggest that could be done by touch a file eg. /var/cachce/pacman/src/gcc-4.0.2.tar.tgz.done to do this. |
This task depends upon
Closed by Aaron Griffin (phrakture)
Monday, 18 December 2006, 17:47 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in CVS
Monday, 18 December 2006, 17:47 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in CVS
But, I wish there is any developer help to check in into archlinux's makepkg.